From b3f82f14f32e0ab297bd31e36fddff5016e0a626 Mon Sep 17 00:00:00 2001
From: dawitbeza <bezadawit90@gmail.com>
Date: Fri, 18 Oct 2024 09:26:28 +0300
Subject: [PATCH 1/2] changing the array that use the variable as their size to
 vector because the dynamic resizing rule

---
 .../C++ Projects/Basic/Calculate CGPA and GPA/main.cpp     | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/Projects/C++ Projects/Basic/Calculate CGPA and GPA/main.cpp b/Projects/C++ Projects/Basic/Calculate CGPA and GPA/main.cpp
index 932f14f..6e34e30 100644
--- a/Projects/C++ Projects/Basic/Calculate CGPA and GPA/main.cpp	
+++ b/Projects/C++ Projects/Basic/Calculate CGPA and GPA/main.cpp	
@@ -5,6 +5,7 @@ special right is given to TEAM TYP for educational purpose  */
 
 #include <iostream>
 #include <stdlib.h>
+#include <vector>
 
 using namespace std;
 
@@ -58,8 +59,8 @@ void calculateGPA()
     cout<<" How many subject's points do you want to calculate? : ";
     cin>>q;
 
-    float credit [q];
-    float point [q];
+    std::vector<int> credit(q);
+    std::vector<int> point(q);
 
     cout<<endl;
     for(int i=0;i<q;i++)
@@ -121,7 +122,7 @@ void calculateCGPA()
     cout<<"How many semester results do you want input? :";
     cin>>l;
     cout<<"\n\n"<<endl;
-    float semrs[l];
+    std::vector<int> semrs(l);
     int i;
 
     for(i=0;i<l;i++)

From 51515dfc86984245664ec60991db60f79de6c83e Mon Sep 17 00:00:00 2001
From: dawitbeza <bezadawit90@gmail.com>
Date: Fri, 18 Oct 2024 13:25:53 +0300
Subject: [PATCH 2/2] changing the goto loop to while loop and introducing the
 new input validation techniques for all the input stream

---
 .../Basic/Calculate CGPA and GPA/main.cpp     | 114 ++++++++++--------
 1 file changed, 67 insertions(+), 47 deletions(-)

diff --git a/Projects/C++ Projects/Basic/Calculate CGPA and GPA/main.cpp b/Projects/C++ Projects/Basic/Calculate CGPA and GPA/main.cpp
index 6e34e30..6fdd01e 100644
--- a/Projects/C++ Projects/Basic/Calculate CGPA and GPA/main.cpp	
+++ b/Projects/C++ Projects/Basic/Calculate CGPA and GPA/main.cpp	
@@ -6,17 +6,21 @@ special right is given to TEAM TYP for educational purpose  */
 #include <iostream>
 #include <stdlib.h>
 #include <vector>
+#include <string>
 
 using namespace std;
 
 void calculateGPA();
 void calculateCGPA();
 void method();
+void inputValidation(int& input, int lowerInputLeveler, int aboveInputLeveler, const string& labelMessage);
 
 int main()
 {
     system("cls");
     int input;
+    int aboveLabel = 4;
+    int lowerLabel = 1;
     cout<<"--------------------------------------------------------------------------"<<endl;
     cout<<"                    GPA & CGPA Calculator (Developed by Nemo)             "<<endl;
     cout<<"--------------------------------------------------------------------------\n"<<endl;
@@ -26,50 +30,52 @@ int main()
     cout<<"                   3. Method that is applied here for calclating GPA & CGPA"<<endl;
     cout<<"                   4. Exit Application"<<endl;
     cout<<"--------------------------------------------------------------------------"<<endl;
-    sub:
-    cout<<"Enter your choice: ";
-    cin>>input;
-    switch(input)
-    {
+        cout << "Enter your choice: ";
+        inputValidation(input, lowerLabel, aboveLabel, "Ente your choice");
+        switch (input)
+        {
         case 1:
-                calculateGPA();
-                break;
+            calculateGPA();
+            break;
 
         case 2:
-                calculateCGPA();
-                break;
+            calculateCGPA();
+            break;
         case 3:
-                method();
-                break;
+            method();
+            break;
         case 4:
-                exit(EXIT_SUCCESS);
-                break;
-        default:
-            cout<<"You have entered wrong input.Try again!\n"<<endl;
-            goto sub;
+            exit(EXIT_SUCCESS);
             break;
+        }
     }
-}
 
 void calculateGPA()
 {
     int q;
     system("cls");
+    //in this case the validation is not made to label rather the size of array,  we make the lower 1 because we cannot calculate anything for 0 subjects
+    int lowerArraysizePossible = 1;
+    int bigArraySizePossible = numeric_limits<int>::max();
+    int lowerGrade = 0;
+    int aboveGrade = 4;
+    int lowerCredit = 0;
+    int aboveCredit = 10;
     cout<<"-------------- GPA Calculating -----------------"<<endl;
     cout<<" How many subject's points do you want to calculate? : ";
-    cin>>q;
+    inputValidation(q, lowerArraysizePossible, bigArraySizePossible, "how many subject's points do you want to calculate");
 
-    std::vector<int> credit(q);
-    std::vector<int> point(q);
+    vector<int> credit(q);
+    vector<int> point(q);
 
     cout<<endl;
     for(int i=0;i<q;i++)
     {
         cout<<"Enter the credit for the subject "<<i+1<<": ";
-        cin>>credit[i];
+        inputValidation(credit[i], lowerGrade, aboveGrade, "Enter the credit for the subject");
         cout<<endl;
         cout<<"Enter the point of the subject "<<i+1<<": ";
-        cin>>point[i];
+        inputValidation(point[i], lowerGrade, aboveGrade, "Enter the point for the subject");
         cout<<"-----------------------------------\n\n"<<endl;
     }
 
@@ -88,15 +94,15 @@ void calculateGPA()
     }
 
     cout<<"\n\n\nTotal Points: "<<sum<<" . Total Credits: "<<totCr<<" .Total GPA: "<<sum/totCr<<" ."<<endl;
-
-
-    sub:
+    //there are 3 labeles to be validated
+    int lowerLabeler = 1;
+    int higherLabeler = 4;
     int inmenu;
     cout<<"\n\n\n1. Calculate Again"<<endl;
     cout<<"2. Go Back to Main Menu"<<endl;
     cout<<"3. Exit This App \n\n"<<endl;
     cout<<"Your Input: "<<endl;
-    cin>>inmenu;
+    inputValidation(inmenu, lowerLabeler, higherLabeler, "Your label input");
 
     switch(inmenu)
     {
@@ -108,27 +114,28 @@ void calculateGPA()
                 break;
         case 3:
                 exit(EXIT_SUCCESS);
-
-        default:
-              cout<<"\n\nYou have Entered Wrong Input!Please Choose Again!"<<endl;
-              goto sub;
     }
 }
 void calculateCGPA()
 {
     system("cls");
+    //the validation parameter for the semister size and the grade input 
+    int lowerSemisterSizePossible = 2;
+    int higherSemisterSizePossible = numeric_limits<int>::max();
+    int lowerGradePossible = 0;//(f)
+    int higherGradePossible = 4;//(A);
     int l;
     cout<<"-------------- CGPA Calculating -----------------\n\n"<<endl;
     cout<<"How many semester results do you want input? :";
-    cin>>l;
+    inputValidation(l, lowerSemisterSizePossible, higherSemisterSizePossible, "how many semseter results do you want input");
     cout<<"\n\n"<<endl;
-    std::vector<int> semrs(l);
+    vector<int> semrs(l);
     int i;
 
     for(i=0;i<l;i++)
     {
         cout<<" Enter Semester "<<i+1<<" Result(GPA): ";
-        cin>>semrs[i];
+        inputValidation(semrs[i], lowerGradePossible, higherGradePossible, "Result CGPA");
         cout<<"\n"<<endl;
     }
 
@@ -138,16 +145,17 @@ void calculateCGPA()
         semtot=semtot+semrs[j];
     }
 
-    cout<<"******** Your CGPA is "<<semtot/l<<" **********"<<endl;
-
+    //the validation paramater for the label
+    int lowerLabel = 1;
+    int aboveLabel = 3;
 
-    sub:
+    cout << "******** Your CGPA is " << semtot / l << " **********" << endl;
     int inmenu;
     cout<<"\n\n\n1. Calculate Again"<<endl;
     cout<<"2. Go Back to Main Menu"<<endl;
     cout<<"3. Exit This App \n\n"<<endl;
     cout<<"Your Input: "<<endl;
-    cin>>inmenu;
+    inputValidation(inmenu, lowerLabel, aboveLabel, "your label input");
 
     switch(inmenu)
     {
@@ -159,28 +167,26 @@ void calculateCGPA()
                 break;
         case 3:
                 exit(EXIT_SUCCESS);
-
-        default:
-              cout<<"\n\nYou have Entered Wrong Input!Please Choose Again!"<<endl;
-              goto sub;
     }
 
 }
 
 void method()
 {
+    //since there are only two leveles that are (go back to mainmenu and exit app)
+    int lowerLabel = 1;
+    int aboveLabel = 2;
     system("cls");
     cout<<"--------------- Method of Calculating GPA & CGPA ---------------\n\n"<<endl;
     cout<<" GPA= Sum of (Credit*Point) / total of credits \n"<<endl;
     cout<<" CGPA=  Sum of GPA / number of semesters "<<endl;
     cout<<"-----------------------------------------------------------------\n\n"<<endl;
 
-    sub:
     int inmenu;
     cout<<"1. Go Back to Main Menu"<<endl;
     cout<<"2. Exit This App \n\n"<<endl;
     cout<<"Your Input: "<<endl;
-    cin>>inmenu;
+    inputValidation(inmenu, lowerLabel, aboveLabel, "your label input");
 
     switch(inmenu)
     {
@@ -189,9 +195,23 @@ void method()
                 break;
         case 2:
                 exit(EXIT_SUCCESS);
-
-        default:
-              cout<<"\n\nYou have Entered Wrong Input!Please Choose Again!"<<endl;
-              goto sub;
     }
 };
+
+void inputValidation(int& input, int lowerBound, int upperBound, const std::string& labelMessage) {
+    while (true) {
+        if (std::cin >> input) {
+            if (input >= lowerBound && input <= upperBound) {
+                break; 
+            }
+            else {
+                std::cout << "Please enter a number between " << lowerBound << " and " << upperBound << " (" << labelMessage << ")" << std::endl;
+            }
+        }
+        else {
+            std::cout << "Invalid input. Please enter a valid number (" << labelMessage << ")" << std::endl;
+            std::cin.clear(); 
+            std::cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');  
+        }
+    }
+}