Skip to content

Commit 836b81d

Browse files
committed
(chocolatey#508) Make package id comparisons case insensitive
This helps ensure that package IDs are handled in a case insensitive manner.
1 parent 06acb28 commit 836b81d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/chocolatey/infrastructure.app/services/NugetService.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,7 @@ public virtual ConcurrentDictionary<string, PackageResult> Install(ChocolateyCon
499499
if (packageNames.Count == 1)
500500
{
501501
var packageName = packageNames.DefaultIfEmpty(string.Empty).FirstOrDefault();
502-
if (packageName.EndsWith(NuGetConstants.PackageExtension) || packageName.EndsWith(PackagingConstants.ManifestExtension))
502+
if (packageName.EndsWith(NuGetConstants.PackageExtension, StringComparison.OrdinalIgnoreCase) || packageName.EndsWith(PackagingConstants.ManifestExtension, StringComparison.OrdinalIgnoreCase))
503503
{
504504
this.Log().Warn(ChocolateyLoggers.Important, "DEPRECATION WARNING");
505505
this.Log().Warn(InstallWithFilePathDeprecationMessage);
@@ -509,7 +509,7 @@ public virtual ConcurrentDictionary<string, PackageResult> Install(ChocolateyCon
509509

510510
config.Sources = _fileSystem.GetDirectoryName(_fileSystem.GetFullPath(packageName));
511511

512-
if (packageName.EndsWith(PackagingConstants.ManifestExtension))
512+
if (packageName.EndsWith(PackagingConstants.ManifestExtension, StringComparison.OrdinalIgnoreCase))
513513
{
514514
packageNames.Add(_fileSystem.GetFilenameWithoutExtension(packageName));
515515

@@ -553,7 +553,7 @@ public virtual ConcurrentDictionary<string, PackageResult> Install(ChocolateyCon
553553

554554
var installedPackage = allLocalPackages.FirstOrDefault(p => p.Name.IsEqualTo(packageName));
555555

556-
if (Platform.GetPlatform() != PlatformType.Windows && !packageName.EndsWith(".template"))
556+
if (Platform.GetPlatform() != PlatformType.Windows && !packageName.EndsWith(".template", StringComparison.OrdinalIgnoreCase))
557557
{
558558
string logMessage = "{0} is not a supported package on non-Windows systems.{1}Only template packages are currently supported.".FormatWith(packageName, Environment.NewLine);
559559
this.Log().Warn(ChocolateyLoggers.Important, logMessage);

0 commit comments

Comments
 (0)