Remove dependency on default list-sessions format#6
Open
voskresenie wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
has_sessiondepends on the default output format oflist-sessionsbeing what it is, ie beginning with#{session_name}:. While it's not particularly likely that the default format will change, and the only practical problem with the way it is happens if the input is something likemy_session: 4 windows (created Tue Oct 22 07[1], this seems like a cleaner way of doing it (that's a joke, I watch your vids). But I understand if you would rather leave it as is.[1] which will match if
my_sessionexists, has 4 windows, and was created Tue Oct 22 between[07:00:00, 08:00:00), in any year that Oct 22 is a Tuesday. But this won't be possible if #5 is merged, since:will be replaced with_