Fix linting errors in tests

Author: SorraTheOrc

tests/balance_studio/test_cli.py

@@ -1,5 +1,3 @@
-import sys
-from pathlib import Path
 from unittest.mock import MagicMock, patch
 
 import pytest
@@ -39,10 +37,16 @@ def test_main_success(mock_script_path):
             # specifically when resolving the script path
             with patch("gengine.balance_studio.cli.Path") as mock_path_cls:
                 # Configure the mock path to point to our temp script
-                # The logic in cli.py is: Path(__file__).resolve().parents[3] / "scripts"
+                # The logic in cli.py is:
+                # Path(__file__).resolve().parents[3] / "scripts"
                 # We'll just mock the final result of that chain
                 mock_resolved_path = MagicMock()
-                mock_resolved_path.parents = [MagicMock(), MagicMock(), MagicMock(), MagicMock()]
+                mock_resolved_path.parents = [
+                    MagicMock(),
+                    MagicMock(),
+                    MagicMock(),
+                    MagicMock(),
+                ]
                 # The 4th parent (index 3) is the root
                 mock_root = mock_resolved_path.parents[3]
                 mock_root.__truediv__.return_value = mock_script_path.parent
@@ -72,4 +76,7 @@ def test_main_script_not_found():
 
             assert result == 1
             mock_stderr.write.assert_called_once()
-            assert "Failed to load Balance Studio script" in mock_stderr.write.call_args[0][0]
+            assert (
+                "Failed to load Balance Studio script"
+                in mock_stderr.write.call_args[0][0]
+            )

tests/balance_studio/test_overlays.py

@@ -1,9 +1,9 @@
+
 import pytest
 import yaml
-from pathlib import Path
+
 from gengine.balance_studio.overlays import (
     ConfigOverlay,
-    create_tuning_overlay,
     deep_merge,
     load_overlay_directory,
     merge_overlays,

tests/balance_studio/test_report_viewer.py

@@ -1,5 +1,3 @@
-import json
-from pathlib import Path
 from unittest.mock import MagicMock, patch
 
 import pytest
@@ -40,15 +38,23 @@ def sample_data():
         "sweeps": [
             {
                 "sweep_id": "1",
-                "parameters": {"strategy": "balanced", "difficulty": "normal", "seed": 42},
+                "parameters": {
+                    "strategy": "balanced",
+                    "difficulty": "normal",
+                    "seed": 42,
+                },
                 "results": {"final_stability": 0.8, "actions_taken": 10},
             },
             {
                 "sweep_id": "2",
-                "parameters": {"strategy": "aggressive", "difficulty": "hard", "seed": 123},
+                "parameters": {
+                    "strategy": "aggressive",
+                    "difficulty": "hard",
+                    "seed": 123,
+                },
                 "results": {"final_stability": 0.2, "actions_taken": 20},
-                "error": "Some error"
-            }
+                "error": "Some error",
+            },
         ]
     }
 

tests/balance_studio/test_workflows.py

@@ -4,7 +4,6 @@
 from unittest.mock import MagicMock, patch
 
 import pytest
-import yaml
 
 from gengine.balance_studio.workflows import (
     CompareConfigsConfig,
@@ -114,7 +113,6 @@ def test_run_config_comparison_success(mock_subprocess_run, mock_datetime, tmp_p
     mock_subprocess_run.return_value.returncode = 0
 
     # Create dummy summary files for both sweeps
-    timestamp = "20230101_120000"
 
     def side_effect(*args, **kwargs):
         # Determine if this is sweep A or B based on args
@@ -165,12 +163,17 @@ def test_run_tuning_test(mock_subprocess_run, mock_datetime, tmp_path):
     )
 
     # Mock yaml loading/dumping
-    with patch("yaml.safe_load") as mock_safe_load,          patch("yaml.safe_dump") as mock_safe_dump:
+    with (
+        patch("yaml.safe_load") as mock_safe_load,
+        patch("yaml.safe_dump"),
+    ):
 
         mock_safe_load.return_value = {"simulation": {"tick_limit": 100}}
 
         # Mock run_config_comparison to avoid complex subprocess mocking again
-        with patch("gengine.balance_studio.workflows.run_config_comparison") as mock_compare:
+        with patch(
+            "gengine.balance_studio.workflows.run_config_comparison"
+        ) as mock_compare:
             mock_compare.return_value = WorkflowResult(
                 workflow_name="compare_configs",
                 success=True,
@@ -180,7 +183,7 @@ def test_run_tuning_test(mock_subprocess_run, mock_datetime, tmp_path):
             )
 
             # We also need to mock file operations for base config
-            with patch("builtins.open", create=True) as mock_open:
+            with patch("builtins.open", create=True):
                 # Setup mock for file existence check
                 with patch("pathlib.Path.exists") as mock_exists:
                     mock_exists.return_value = True
@@ -244,7 +247,8 @@ def test_list_historical_reports(tmp_path):
     reports = list_historical_reports(reports_dir=reports_dir)
 
     assert len(reports) == 2
-    # Should be sorted reverse by path (which usually correlates with time if named correctly)
+    # Should be sorted reverse by path
+    # (which usually correlates with time if named correctly)
     # But glob order depends on OS.
     # Let's just check content.
     timestamps = [r["timestamp"] for r in reports]
@@ -266,7 +270,9 @@ def test_get_workflow_menu():
     assert "view_reports" in ids
 
 
-def test_run_exploratory_sweep_with_overlay(mock_subprocess_run, mock_datetime, tmp_path):
+def test_run_exploratory_sweep_with_overlay(
+    mock_subprocess_run, mock_datetime, tmp_path
+):
     """Test exploratory sweep with overlay."""
     from gengine.balance_studio.overlays import ConfigOverlay
 

tests/scripts/test_echoes_balance_studio.py

@@ -496,14 +496,20 @@ def mock_cli_workflows():
          patch(f"{module_name}.write_html_report") as mock_write:
 
         # Setup default success returns
-        mock_sweep.return_value = MagicMock(success=True, message="Success", output_path="out", errors=[])
+        mock_sweep.return_value = MagicMock(
+            success=True, message="Success", output_path="out", errors=[]
+        )
 
         # Fix for JSON serialization: to_dict should return a real dict
-        compare_result = MagicMock(success=True, message="Success", output_path="out", data={}, errors=[])
+        compare_result = MagicMock(
+            success=True, message="Success", output_path="out", data={}, errors=[]
+        )
         compare_result.to_dict.return_value = {"success": True, "message": "Success"}
         mock_compare.return_value = compare_result
 
-        mock_tuning.return_value = MagicMock(success=True, message="Success", output_path="out", data={}, errors=[])
+        mock_tuning.return_value = MagicMock(
+            success=True, message="Success", output_path="out", data={}, errors=[]
+        )
         mock_list.return_value = []
         mock_view.return_value = MagicMock(success=True, message="Success", data={})
 
@@ -532,7 +538,8 @@ def test_interactive_mode_invalid(self, mock_cli_workflows):
 
     def test_interactive_mode_sweep(self, mock_cli_workflows):
         """Test selecting sweep workflow."""
-        with patch("builtins.input", side_effect=["1", "", "", "", ""]): # Select 1, then defaults for sweep
+        # Select 1, then defaults for sweep
+        with patch("builtins.input", side_effect=["1", "", "", "", ""]):
             assert _cli.interactive_mode() == 0
             mock_cli_workflows["sweep"].assert_called_once()
 
@@ -548,7 +555,9 @@ def test_interactive_sweep_defaults(self, mock_cli_workflows):
 
     def test_interactive_sweep_custom(self, mock_cli_workflows):
         """Test interactive sweep with custom inputs."""
-        with patch("builtins.input", side_effect=["strat1, strat2", "hard", "1, 2", "50"]):
+        with patch(
+            "builtins.input", side_effect=["strat1, strat2", "hard", "1, 2", "50"]
+        ):
             assert _cli.interactive_sweep() == 0
             args = mock_cli_workflows["sweep"].call_args[0][0]
             assert args.strategies == ["strat1", "strat2"]
@@ -558,7 +567,9 @@ def test_interactive_sweep_custom(self, mock_cli_workflows):
 
     def test_interactive_compare_success(self, mock_cli_workflows):
         """Test interactive compare workflow."""
-        with patch("builtins.input", side_effect=["path/a", "Name A", "path/b", "Name B"]):
+        with patch(
+            "builtins.input", side_effect=["path/a", "Name A", "path/b", "Name B"]
+        ):
             assert _cli.interactive_compare() == 0
             args = mock_cli_workflows["compare"].call_args[0][0]
             assert str(args.config_a_path) == "path/a"
@@ -573,7 +584,10 @@ def test_interactive_compare_missing_path(self, mock_cli_workflows):
 
     def test_interactive_tuning_success(self, mock_cli_workflows):
         """Test interactive tuning workflow."""
-        with patch("builtins.input", side_effect=["test_exp", "economy.regen=1.5", "invalid", "flag=true", ""]):
+        with patch(
+            "builtins.input",
+            side_effect=["test_exp", "economy.regen=1.5", "invalid", "flag=true", ""],
+        ):
             assert _cli.interactive_tuning() == 0
             args = mock_cli_workflows["tuning"].call_args[0][0]
             assert args.name == "test_exp"
@@ -592,17 +606,32 @@ def test_interactive_view_reports_empty(self, mock_cli_workflows):
     def test_interactive_view_reports_select(self, mock_cli_workflows):
         """Test selecting a report to view."""
         mock_cli_workflows["list"].return_value = [
-            {"timestamp": "2023", "completed_sweeps": 1, "total_sweeps": 1, "strategies": ["s"], "path": "p"}
+            {
+                "timestamp": "2023",
+                "completed_sweeps": 1,
+                "total_sweeps": 1,
+                "strategies": ["s"],
+                "path": "p",
+            }
         ]
-        mock_cli_workflows["view"].return_value.data = {"strategy_stats": {"s": {"avg_stability": 0.5}}}
+        mock_cli_workflows["view"].return_value.data = {
+            "strategy_stats": {"s": {"avg_stability": 0.5}}
+        }
 
         with patch("builtins.input", side_effect=["1"]):
             assert _cli.interactive_view_reports() == 0
             mock_cli_workflows["view"].assert_called_once()
 
     def test_interactive_view_reports_quit(self, mock_cli_workflows):
         """Test quitting report viewer."""
-        mock_cli_workflows["list"].return_value = [{"timestamp": "2023", "completed_sweeps": 1, "total_sweeps": 1, "strategies": ["s"]}]
+        mock_cli_workflows["list"].return_value = [
+            {
+                "timestamp": "2023",
+                "completed_sweeps": 1,
+                "total_sweeps": 1,
+                "strategies": ["s"],
+            }
+        ]
         with patch("builtins.input", side_effect=["q"]):
             assert _cli.interactive_view_reports() == 0
 
@@ -666,7 +695,15 @@ def test_cmd_view_reports(self, mock_cli_workflows):
         args.limit = 5
         args.json = False
 
-        mock_cli_workflows["list"].return_value = [{"timestamp": "t", "completed_sweeps": 1, "total_sweeps": 1, "strategies": ["s"], "path": "p"}]
+        mock_cli_workflows["list"].return_value = [
+            {
+                "timestamp": "t",
+                "completed_sweeps": 1,
+                "total_sweeps": 1,
+                "strategies": ["s"],
+                "path": "p",
+            }
+        ]
 
         assert _cli.cmd_view_reports(args) == 0
         mock_cli_workflows["list"].assert_called_once()