Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlucas/phpdotenv version not supported by philippbaschke/acf-pro-installer #1

Open
matbrady opened this issue Jul 14, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@matbrady
Copy link
Member

matbrady commented Jul 14, 2020

The project requires version ^3.1.0 of the vlucas/phpdotenv package which is unsupported by what appears to be the unmaintained philippbaschke/acf-pro-installer.

This needs to be investigated more. Feels like Pantheons composer example as lagging behind Bedrock.

Solution

The short term solution is to downgrade the vlucas/phpdotenv version to ^2.6. Bedrock currently relies on ^4.1.5 of vlucas/phpdotenv.

@matbrady matbrady added the bug Something isn't working label Jul 14, 2020
@Henryhankdc
Copy link

What we need to do is replace the unmaintained philippbaschke/acf-pro-installer with ffraenz / private-composer-installer as per this comment.

This is what Ted used on AMP/AMC

{
  "type": "package",
  "package": {
    "name": "advanced-custom-fields/advanced-custom-fields-pro",
    "version": "5.8.12",
    "type": "wordpress-plugin",
    "dist": {
      "type": "zip",
      "url": "https://connect.advancedcustomfields.com/index.php?a=download&p=pro&k={%ACF_PRO_KEY}&t={%VERSION}"
    },
    "require": {
      "composer/installers": "^1.4",
      "ffraenz/private-composer-installer": "^4.0"
    }
  }
}

@matbrady
Copy link
Member Author

matbrady commented Aug 7, 2020

side note, this also requires upgrading vlucas/phpdotenv:^4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants