-
-
Notifications
You must be signed in to change notification settings - Fork 423
Feat: persist apps sort order into config #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: persist apps sort order into config #438
Conversation
|
Hey, I'm thinking we extend this a little more. What do you think about leaving name as the default sort but saving the selected sort method to config, so that it persists between uses? |
Yes that's what I said in the issue #435 related to this PR. I've done it in the last commit :) |
waffles-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're close - make the appropriate changes but don't catch up to latest main just yet. We need one of the changes made for podman fixed first before you'll be able to test it. I currently have this pencilled in for 0.9 - thanks
|
I moved to onMounted() function like you said. |
My apologies, I've been away. Can you please catch up to (pull in) latest main + resolve conflicts, now that the podman work is in? I'll then run it up and check it out, I might need talk to Tibix about the latency issue. |
7e12b53 to
04bd1be
Compare
|
I've re-based and re-runned, the save of the filter works like a charm 👍 -- Unrelated, after pulled main and starting Winboat, it tried to update the guest server but failed. I follow the tutorial in this case (https://rentry.org/winboat_guest_server_borked) and saw that
Not much logs into Nothing special in |
Hi !
As said in #435 this first easy solution :)