4040import java .util .Arrays ;
4141import java .util .Objects ;
4242import java .util .Optional ;
43- import java .util .Properties ;
43+ import java .util .stream . Stream ;
4444
4545import org .openjdk .jmh .profile .AsyncProfiler ;
4646import org .openjdk .jmh .results .format .ResultFormatType ;
4949import org .slf4j .Logger ;
5050import org .slf4j .LoggerFactory ;
5151
52- public abstract class AbstractMain <C extends AbstractConfiguration > {
52+ import one .convert .Arguments ;
53+ import one .profiler .AsyncProfilerLoader ;
5354
54- private static final Logger STATIC_LOGGER = LoggerFactory . getLogger ( AbstractMain . class );
55+ public abstract class AbstractMain < C extends AbstractConfiguration > {
5556
5657 protected final Logger LOGGER = LoggerFactory .getLogger (getClass ());
58+
5759 private final String subpackage ;
5860 protected final Path resultsDirectory ;
5961
@@ -81,21 +83,11 @@ protected static String getTimestamp() {
8183 return year + month + day + "_" + hour + minute + second ;
8284 }
8385
84- protected static Optional <Path > getAsyncProfilerPath () {
86+ protected Optional <Path > getAsyncProfilerPath () {
8587 try {
86- var properties = new Properties ();
87- properties .load (AbstractMain .class .getResourceAsStream ("/buildtime.properties" ));
88- var asyncProfilerPath = Path .of (
89- properties .getProperty ("async.profiler.path" ).trim (),
90- "lib" ,
91- "libasyncProfiler.so" )
92- .toAbsolutePath ();
93- if (!asyncProfilerPath .toFile ().exists ()) {
94- return Optional .empty ();
95- }
96- return Optional .of (asyncProfilerPath );
97- } catch (IOException e ) {
98- STATIC_LOGGER .error ("Failed reading buildtime.properties from the benchmarks JAR." , e );
88+ return Optional .of (AsyncProfilerLoader .getAsyncProfilerPath ());
89+ } catch (Exception e ) {
90+ LOGGER .error ("Failed loading AsyncProfiler." , e );
9991 return Optional .empty ();
10092 }
10193 }
@@ -115,24 +107,34 @@ protected ChainedOptionsBuilder initAsyncProfiler(ChainedOptionsBuilder options)
115107 });
116108 }
117109
118- protected void convertJfrToFlameGraphs () {
110+ protected void visualizeJfr () {
119111 if (getAsyncProfilerPath ().isPresent ()) {
120112 var combinedJfr = resultsDirectory .resolve ("combined.jfr" );
121- var jfrAssembleLog = resultsDirectory .resolve ("jfr-assemble.log" );
113+ // JFR will create the combined file before it finishes combining all of the inputs.
114+ // Because the command looks at the entire directory, this will make the combined file part of the inputs.
115+ // And this will cause an unkillable JFR process on MacOS.
116+ // Therefore we combine the JFR files to a file outside the directory,
117+ // and only when fully combined we move it over to the results folder.
118+ var tmpCombinedJfr = resultsDirectory .getParent ().resolve ("combined.jfr" );
122119 try {
123120 // Merge all the JFR files that were generated by JMH and copied over by our custom JMH runner.
124121 var process = new ProcessBuilder ()
125122 .command ("jfr" , "assemble" , resultsDirectory .toAbsolutePath ().toString (),
126- combinedJfr .toAbsolutePath ().toString ())
127- .redirectOutput ( jfrAssembleLog . toFile () )
123+ tmpCombinedJfr .toAbsolutePath ().toString ())
124+ .inheritIO ( )
128125 .start ();
129126 if (process .waitFor () != 0 ) {
130- LOGGER .error ("Failed combining JFR files. See '{}' for details." , jfrAssembleLog );
127+ LOGGER .error ("Failed combining JFR files." );
131128 return ;
132129 }
133- // From the combined JMH file, create flame graphs.
134- generateFlameGraphsFromJfr (combinedJfr , null );
135- generateFlameGraphsFromJfr (combinedJfr , "alloc" );
130+ Files .move (tmpCombinedJfr , combinedJfr );
131+ LOGGER .error ("Combined JFR files to {}." , combinedJfr );
132+ // From the combined JMH file, create visualizations.
133+ for (var visualizationType : VisualizationType .values ()) {
134+ for (var dataType : DataType .values ()) {
135+ visualizeJfr (combinedJfr , visualizationType , dataType );
136+ }
137+ }
136138 } catch (Exception e ) {
137139 LOGGER .error ("Failed converting JFR to flame graphs." , e );
138140 }
@@ -141,25 +143,31 @@ protected void convertJfrToFlameGraphs() {
141143 }
142144 }
143145
144- private static void generateFlameGraphsFromJfr (Path jfrFilePath , String type ) {
145- var args = type == null ? new String [] {
146- "--simple" ,
147- jfrFilePath .toString (),
148- Path .of (jfrFilePath .toAbsolutePath ().getParent ().toString (), "cpu.html" ).toString ()
149- }
150- : new String [] {
151- "--simple" ,
152- "--" + type ,
153- jfrFilePath .toString (),
154- Path .of (jfrFilePath .toAbsolutePath ().getParent ().toString (), type + ".html" ).toString ()
155- };
156- try { // Converter is stupidly in the default package.
157- var fooClass = Class .forName ("jfr2flame" );
158- var fooMethod = fooClass .getMethod ("main" , String [].class );
159- fooMethod .invoke (null , (Object ) args );
160- STATIC_LOGGER .info ("Generating flame graph succeeded: {}." , Arrays .toString (args ));
146+ private void visualizeJfr (Path jfrFilePath , VisualizationType visualizationType , DataType dataType ) {
147+ var inputPath = jfrFilePath .toAbsolutePath ();
148+ var filename = String .format ("%s-%s.html" , dataType .name , visualizationType .name );
149+ var output = Path .of (inputPath .getParent ().toString (), filename );
150+ var argStream = Stream .of (
151+ "--simple" , // Shorter names.
152+ // "--norm" removes random strings from lambdas;
153+ // allows to merge different frames which are only different
154+ // because they use a different instance of the same lambda.
155+ "--norm" ,
156+ // "--skip 15" removes bottom frames which come from JMH; they are unnecessary clutter.
157+ "--skip" , "15" ,
158+ "--" + dataType .name );
159+ var args = argStream .toArray (String []::new );
160+ try {
161+ if (visualizationType == VisualizationType .FLAME_GRAPH ) {
162+ one .convert .JfrToFlame .convert (inputPath .toString (), output .toString (), new Arguments (args ));
163+ } else if (visualizationType == VisualizationType .HEAT_MAP ) {
164+ one .convert .JfrToHeatmap .convert (inputPath .toString (), output .toString (), new Arguments (args ));
165+ } else {
166+ throw new IllegalArgumentException ("Unsupported visualization: " + visualizationType );
167+ }
168+ LOGGER .info ("{} Generation succeeded: {}." , visualizationType , Arrays .toString (args ));
161169 } catch (Exception ex ) {
162- STATIC_LOGGER .error ("Generating flame graph failed: {}." , Arrays .toString (args ), ex );
170+ LOGGER .error ("{} Generation failed: {}." , visualizationType , Arrays .toString (args ), ex );
163171 }
164172 }
165173
@@ -193,4 +201,30 @@ public ChainedOptionsBuilder getBaseJmhConfig(C configuration) {
193201 .shouldDoGC (true );
194202 }
195203
204+ private enum VisualizationType {
205+
206+ FLAME_GRAPH ("flamegraph" ),
207+ HEAT_MAP ("heatmap" );
208+
209+ private final String name ;
210+
211+ VisualizationType (String name ) {
212+ this .name = Objects .requireNonNull (name );
213+ }
214+
215+ }
216+
217+ private enum DataType {
218+
219+ CPU ("cpu" ),
220+ MEM ("alloc" );
221+
222+ private final String name ;
223+
224+ DataType (String name ) {
225+ this .name = Objects .requireNonNull (name );
226+ }
227+
228+ }
229+
196230}
0 commit comments