From 2b62e378139d0d2e4cda86d57c2f8a5416dfd535 Mon Sep 17 00:00:00 2001 From: Tom Augspurger Date: Wed, 12 Feb 2025 10:36:01 -0800 Subject: [PATCH] Add some downstream tests https://github.com/rapidsai/rapids-dask-dependency/pull/85 changes the dask dependency to use released versions of Dask. To catch prominant breakage in downstream libraries (like dask-cudf) with dask main, we'll add some novel tests here that run downstream (cudf) nightly against upstream (dask) `main`. --- README.md | 2 ++ downstream/test_downstream.py | 14 ++++++++++++++ scripts/run.sh | 1 + scripts/test.sh | 9 ++++++++- 4 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 downstream/test_downstream.py diff --git a/README.md b/README.md index c635c6e..4d70a2f 100644 --- a/README.md +++ b/README.md @@ -2,6 +2,8 @@ This repository contains the scripts to run Dask's `gpu`-marked tests on a schedule. +In addition, we run some light downstream tests, as an early warning check for breaking in downstream packages like cuDF, dask-cuDF, and cuML. + ## Version Policy The primary goal here is to quickly identify breakages in tests defined in `dask/dask` and `dask/distributed`, so we'll use the latest `main` from each of those. diff --git a/downstream/test_downstream.py b/downstream/test_downstream.py new file mode 100644 index 0000000..46d4cb5 --- /dev/null +++ b/downstream/test_downstream.py @@ -0,0 +1,14 @@ +def test_import_cudf(): + import cudf # noqa: F401 + + +def test_import_dask_cudf(): + import dask_cudf # noqa: F401 + + +def test_import_cuml(): + import cuml # noqa: F401 + + +def test_dask_cuda(): + import dask_cuda # noqa: F401 \ No newline at end of file diff --git a/scripts/run.sh b/scripts/run.sh index 882493d..5cab3ed 100755 --- a/scripts/run.sh +++ b/scripts/run.sh @@ -19,6 +19,7 @@ pip install --extra-index-url=https://pypi.anaconda.org/rapidsai-wheels-nightly/ "cudf-${RAPIDS_PY_CUDA_SUFFIX}" \ "dask-cudf-${RAPIDS_PY_CUDA_SUFFIX}" \ "ucx-py-${RAPIDS_PY_CUDA_SUFFIX}" \ + "cuml-${RAPIDS_PY_CUDA_SUFFIX}" \ "scipy" \ "dask-cuda" diff --git a/scripts/test.sh b/scripts/test.sh index 7258856..0d3494d 100755 --- a/scripts/test.sh +++ b/scripts/test.sh @@ -13,7 +13,14 @@ pytest distributed -v -m gpu --runslow distributed_status=$? popd -if [ $dask_status -ne 0 ] || [ $distributed_status -ne 0 ]; then +echo "[testing downstream]" + +pushd downstream +pytest -v . +downstream_status=$? +popd + +if [ $dask_status -ne 0 ] || [ $distributed_status -ne 0 ] || [ $downstream_status -ne 0 ] ; then echo "Tests faild" exit 1 fi