-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCB cutout not included #41
Comments
i'm not sure it's an issue with this script but with Kicad himself. |
Hi, thanks for reporting this. It is indeed missing as EasyEDA consider the cutout as not just a regular shape on the Edge.Cuts layer, but as a solidregion which was not handled. I added a handler for the simple polygons cutouts, unfortunately I do not have the time to look deeper into it and try to understand the logic of how EasyEDA parse the more complex shapes. The polygons function correctly once they are placed on a board, but the 3D preview may not display correctly in some instances. I am unsure of the reason for this issue : Help would be greatly appreciated to handle more complex shapes and solve the previous issue. If you want to help, the current handler can be found in the footprint handler file : JLC2KiCad_lib/JLC2KiCadLib/footprint/footprint_handlers.py Lines 329 to 337 in fd492d0
|
Thanks for you effort! I will check out the new version when I have time. Maybe if I have time in the future, and feel the need, I will investigate |
Describe the bug
PCB cutout not included when creating footprint
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I would expect the lib to also be able to include cutouts in the parts
Screenshots
![image](https://user-images.githubusercontent.com/21336626/226183519-f9e30e38-12b7-4730-8637-ff1ee5582605.png)
EasyEDA:
KiCad:
![image](https://user-images.githubusercontent.com/21336626/226183546-2f65f62c-7345-4d69-bb97-7c9a404f2cf6.png)
The text was updated successfully, but these errors were encountered: