Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making a button larger on mobile #2586

Open
kingalg opened this issue Aug 1, 2024 · 4 comments
Open

Making a button larger on mobile #2586

kingalg opened this issue Aug 1, 2024 · 4 comments

Comments

@kingalg
Copy link
Collaborator

kingalg commented Aug 1, 2024

Version: 2.2.1-alpha.1
System: android and iOS

Issue: the button's height is 45dp. Consider making the height of this touch target 48dp or larger to make it more accessible.
Google Console pointed out this issue, so we should fix it to avoid errors on Google Play. As the change is insignificant, only 3dp, we don't need new designs.

Where to find the button: it's on a "Join community screen". Please check if the "Continue" button on the "Register a username" screen doesn't have the same problem. If yes, make both of their heights 48dp.

image
Screenshot 2024-08-01 at 12 41 48

@jgaylor
Copy link
Collaborator

jgaylor commented Aug 7, 2024

@kingalg I'm unable to see the view in question as the images are 404s for me. If it's this view they are 48px height in FIgma, so that's preferred.

If you're talking about our primary action buttons, the large ones should be 50px height, and the small ones 32px height. Targets on the 32px height buttons should be at least 48px though. I agree.

Hope this helps

@kingalg
Copy link
Collaborator Author

kingalg commented Aug 9, 2024

I'll try again. For some reason those images are not displayed in some browsers. I didn't tag you @jgaylor because this change is so small that we don't need naw designs. I believe that maybe our current designs show those dimensions correctly.

Screenshot 2024-08-09 at 15 25 58

@holmesworcester
Copy link
Contributor

@kingalg you're saying that if we make the button sizes match designs then we're good?

@kingalg
Copy link
Collaborator Author

kingalg commented Aug 13, 2024

@holmesworcester if this is what Jason called "primary action button" (and I think that it is) then yes - let's make it 50px like in the design and we are good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog - Mobile
Development

No branches or pull requests

3 participants