Resolved warnings during build and updated docs source

- Changed catching of runtime errors in code to by ref instead of by value in order to resolve warnings.
  https://stackoverflow.com/questions/62030341/what-is-this-catching-polymorphic-type-x-by-value-wcatch-value

- Changed all occurences of `#include <boost/bind.hpp>` to `#include<boost/bind/bind.hpp>` with `using namespace boost::placeholders` to resolve boost warnings with new version of boost.

Author: geoffreygarrett

cmake_modules/compiler.cmake

@@ -125,7 +125,8 @@
                  " -Wall"
                  " -Wextra"
                  " -Wno-unused-parameter"
-                 " -Wno-unused-variable")
+                 " -Wno-unused-variable"
+                 )
          string(CONCAT CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
 
      elseif (WIN32)

docs/doxygen/Doxyfile renamed to docs/doxygen/Doxyfile.in

@@ -51,14 +51,14 @@ PROJECT_BRIEF          =
 # pixels and the maximum width should not exceed 200 pixels. Doxygen will copy
 # the logo to the output directory.
 
-PROJECT_LOGO           =
+PROJECT_LOGO           = ../img.png
 
 # The OUTPUT_DIRECTORY tag is used to specify the (relative or absolute) path
 # into which the generated documentation will be written. If a relative path is
 # entered, it will be relative to the location where doxygen was started. If
 # left blank the current directory will be used.
 
-OUTPUT_DIRECTORY       =
+OUTPUT_DIRECTORY       =  @DOXYGEN_OUTPUT_DIRECTORY
 
 # If the CREATE_SUBDIRS tag is set to YES then doxygen will create 4096 sub-
 # directories (in 2 levels) under the output directory of each output format and
@@ -68,7 +68,7 @@ OUTPUT_DIRECTORY       =
 # performance problems for the file system.
 # The default value is: NO.
 
-CREATE_SUBDIRS         = NO
+CREATE_SUBDIRS         = YES
 
 # If the ALLOW_UNICODE_NAMES tag is set to YES, doxygen will allow non-ASCII
 # characters to appear in the names of generated files. If set to NO, non-ASCII

docs/img.png

@@ -39,11 +39,12 @@
     'sphinxcontrib.napoleon',
     'breathe',
 ]
+import os
 
 # Breathe
 breathe_default_project = "Tudat"
 breathe_projects = {}
-breathe_projects["Tudat"] = "../../doxygen/xml"
+breathe_projects["Tudat"] = os.path.join(os.environ.pop("DOXYGEN_OUTPUT_DIRECTORY", "../doxygen"), "xml")
 
 # Add any paths that contain templates here, relative to this directory.
 templates_path = ['_templates']

docs/sphinx/source/conf.py

@@ -14,12 +14,15 @@
 #include <vector>
 
 #include <functional>
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 
 #include <Eigen/Core>
 
 #include "tudat/basics/basicTypedefs.h"
 #include "tudat/astro/aerodynamics/aerodynamics.h"
+
+using namespace boost::placeholders;
+
 namespace tudat
 {
 

include/tudat/astro/aerodynamics/controlSurfaceAerodynamicCoefficientInterface.h

@@ -13,14 +13,16 @@
 
 #include <boost/lambda/lambda.hpp>
 #include <functional>
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 #include <boost/make_shared.hpp>
 
 #include "tudat/astro/aerodynamics/aerodynamicCoefficientInterface.h"
 #include "tudat/astro/aerodynamics/aerodynamicCoefficientGenerator.h"
 #include "tudat/astro/aerodynamics/hypersonicLocalInclinationAnalysis.h"
 #include "tudat/basics/basicTypedefs.h"
 
+using namespace boost::placeholders;
+
 namespace tudat
 {
 namespace aerodynamics

include/tudat/astro/aerodynamics/customAerodynamicCoefficientInterface.h

@@ -20,7 +20,7 @@
 #ifndef TUDAT_CUSTOM_CONSTANT_TEMPERATURE_ATMOSPHERE_H
 #define TUDAT_CUSTOM_CONSTANT_TEMPERATURE_ATMOSPHERE_H
 
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 #include <boost/function.hpp>
 #include <boost/shared_ptr.hpp>
 
@@ -32,6 +32,8 @@
 #include "tudat/astro/aerodynamics/standardAtmosphere.h"
 #include "tudat/astro/basic_astro/physicalConstants.h"
 
+using namespace boost::placeholders;
+
 namespace tudat
 {
 

include/tudat/astro/aerodynamics/customConstantTemperatureAtmosphere.h

@@ -14,7 +14,7 @@
 #include <vector>
 
 #include <functional>
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 
 #include "tudat/astro/aerodynamics/trimOrientation.h"
 #include "tudat/astro/aerodynamics/aerodynamicCoefficientInterface.h"
@@ -23,6 +23,8 @@
 #include "tudat/astro/reference_frames/aerodynamicAngleCalculator.h"
 #include "tudat/basics/basicTypedefs.h"
 
+using namespace boost::placeholders;
+
 namespace tudat
 {
 

include/tudat/astro/aerodynamics/flightConditions.h

@@ -30,7 +30,7 @@
 #ifndef TUDAT_CONVERT_MEAN_ANOMALY_TO_ECCENTRIC_ANOMALY_H
 #define TUDAT_CONVERT_MEAN_ANOMALY_TO_ECCENTRIC_ANOMALY_H
 
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 #include <memory>
 #include <boost/make_shared.hpp>
 #include <boost/math/special_functions/asinh.hpp>
@@ -42,6 +42,8 @@
 #include "tudat/math/basic/basicMathematicsFunctions.h"
 #include "tudat/math/basic/functionProxy.h"
 
+using namespace boost::placeholders;
+
 namespace tudat
 {
 
@@ -236,7 +238,8 @@ ScalarType convertMeanAnomalyToEccentricAnomaly(
             eccentricAnomaly = rootFinder->execute( rootFunction, initialGuess );
         }
         // Use bisection algorithm if root finder fails
-        catch( std::runtime_error )
+        catch( std::runtime_error const& )
+
         {
             // Set tolerance
             ScalarType tolerance = 10.0 * std::numeric_limits< ScalarType >::epsilon( );
@@ -389,7 +392,8 @@ ScalarType convertMeanAnomalyToHyperbolicEccentricAnomaly(
             hyperbolicEccentricAnomaly = rootFinder->execute( rootFunction, initialGuess );
 
         }
-        catch( std::runtime_error )
+        catch( std::runtime_error const& )
+
         {
             rootFinder = createRootFinder< ScalarType >(
                         bisectionRootFinderSettings(

include/tudat/astro/basic_astro/convertMeanToEccentricAnomalies.h

@@ -16,7 +16,7 @@
 #include <string>
 
 #include <functional>
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 #include <boost/make_shared.hpp>
 
 #include <Eigen/Core>
@@ -30,7 +30,7 @@
 #include "tudat/interface/sofa/fundamentalArguments.h"
 #include "tudat/io/basicInputOutput.h"
 
-
+using namespace boost::placeholders;
 
 namespace tudat
 {

include/tudat/astro/earth_orientation/shortPeriodEarthOrientationCorrectionCalculator.h

@@ -16,14 +16,16 @@
 
 #include <boost/function.hpp>
 #include <boost/lambda/lambda.hpp>
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 #include <boost/function.hpp>
 
 #include <Eigen/Core>
 
 #include "tudat/astro/basic_astro/accelerationModel.h"
 #include "tudat/astro/electromagnetism/radiationPressureInterface.h"
 
+using namespace boost::placeholders;
+
 namespace tudat
 {
 

include/tudat/astro/electromagnetism/panelledRadiationPressure.h

@@ -13,7 +13,7 @@
 
 #include <vector>
 
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 #include <memory>
 #include <boost/make_shared.hpp>
 
@@ -24,6 +24,7 @@
 #include "tudat/astro/ephemerides/rotationalEphemeris.h"
 #include "tudat/astro/ephemerides/constantEphemeris.h"
 
+using namespace boost::placeholders;
 
 namespace tudat
 {

include/tudat/astro/ephemerides/compositeEphemeris.h

@@ -14,7 +14,7 @@
 #include <vector>
 
 #include <boost/make_shared.hpp>
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 
 #include "tudat/math/basic/mathematicalConstants.h"
 
@@ -23,6 +23,8 @@
 #include "tudat/astro/ephemerides/compositeEphemeris.h"
 #include "tudat/astro/ephemerides/constantEphemeris.h"
 
+using namespace boost::placeholders;
+
 namespace tudat
 {
 

include/tudat/astro/ephemerides/frameManager.h

@@ -14,13 +14,15 @@
 
 #if TUDAT_BUILD_WITH_SOFA_INTERFACE
 
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 
 #include "tudat/math/basic/linearAlgebra.h"
 #include "tudat/math/interpolators/interpolator.h"
 #include "tudat/astro/ephemerides/rotationalEphemeris.h"
 #include "tudat/astro/earth_orientation/earthOrientationCalculator.h"
 
+using namespace boost::placeholders;
+
 namespace tudat
 {
 

include/tudat/astro/ephemerides/itrsToGcrsRotationModel.h

@@ -13,7 +13,7 @@
 
 #include <functional>
 #include <boost/multi_array.hpp>
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 
 #include <Eigen/Core>
 #include <Eigen/Geometry>
@@ -27,6 +27,8 @@
 #include "tudat/math/basic/legendrePolynomials.h"
 #include "tudat/astro/gravitation/gravityFieldVariations.h"
 
+using namespace boost::placeholders;
+
 namespace tudat
 {
 

include/tudat/astro/gravitation/basicSolidBodyTideGravityFieldVariations.h

@@ -15,7 +15,7 @@
 #include <functional>
 #include <boost/lambda/lambda.hpp>
 #include <memory>
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 #include <boost/make_shared.hpp>
 
 #include <Eigen/Core>
@@ -27,6 +27,8 @@
 #include "tudat/math/basic/legendrePolynomials.h"
 #include "tudat/basics/basicTypedefs.h"
 
+using namespace boost::placeholders;
+
 namespace tudat
 {
 

include/tudat/astro/gravitation/mutualSphericalHarmonicGravityModel.h

@@ -13,14 +13,16 @@
 #define TUDAT_POINTINGANGLESCALCULATOR_H
 
 #include <memory>
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 
 #include <Eigen/Core>
 #include <Eigen/Geometry>
 
 #include "tudat/astro/ephemerides/rotationalEphemeris.h"
 #include "tudat/astro/ground_stations/groundStationState.h"
 
+using namespace boost::placeholders;
+
 namespace tudat
 {
 

include/tudat/astro/ground_stations/pointingAnglesCalculator.h

@@ -20,7 +20,7 @@
 
 #include <Eigen/Geometry>
 
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 #include <functional>
 
 #if( TUDAT_BUILD_WITH_PAGMO )
@@ -32,6 +32,7 @@
 
 #include "tudat/astro/low_thrust/lowThrustLeg.h"
 
+using namespace boost::placeholders;
 
 namespace tudat
 {

include/tudat/astro/low_thrust/lowThrustLegSettings.h

@@ -20,7 +20,7 @@
 
 #include <Eigen/Geometry>
 
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 #include <functional>
 
 #include "tudat/astro/low_thrust/simsFlanagan.h"
@@ -32,6 +32,7 @@
 #include "pagmo/io.hpp"
 #include "pagmo/problem.hpp"
 
+using namespace boost::placeholders;
 
 namespace tudat
 {

include/tudat/astro/low_thrust/lowThrustOptimisationSetup.h

@@ -13,7 +13,7 @@
 
 #include <vector>
 
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 #include <memory>
 #include <functional>
 
@@ -27,6 +27,8 @@
 #include "tudat/astro/observation_models/observableTypes.h"
 #include "tudat/astro/observation_models/observationBias.h"
 
+using namespace boost::placeholders;
+
 namespace tudat
 {
 

include/tudat/astro/observation_models/observationModel.h

@@ -11,7 +11,7 @@
 #ifndef TUDAT_POSITIONOBSERVATIONMODEL_H
 #define TUDAT_POSITIONOBSERVATIONMODEL_H
 
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 #include <functional>
 
 #include "tudat/astro/ephemerides/ephemeris.h"

include/tudat/astro/observation_models/positionObservationModel.h

@@ -12,7 +12,9 @@
 #define TUDAT_SIMULATEOBSERVATIONS_H
 
 #include <memory>
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
+using namespace boost::placeholders;
+
 
 #include "tudat/astro/observation_models/observationSimulator.h"
 #include "tudat/basics/utilities.h"

include/tudat/astro/observation_models/simulateObservations.h

@@ -11,7 +11,9 @@
 #ifndef TUDAT_VELOCITYOBSERVATIONMODEL_H
 #define TUDAT_VELOCITYOBSERVATIONMODEL_H
 
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
+using namespace boost::placeholders;
+
 #include <boost/function.hpp>
 
 #include "tudat/astro/ephemerides/ephemeris.h"

include/tudat/astro/observation_models/velocityObservationModel.h

@@ -15,7 +15,9 @@
 #include <map>
 #include <Eigen/Core>
 
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
+using namespace boost::placeholders;
+
 
 #include "tudat/astro/basic_astro/accelerationModel.h"