Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn per workspace #29

Open
odahcam opened this issue Aug 23, 2018 · 3 comments
Open

Spawn per workspace #29

odahcam opened this issue Aug 23, 2018 · 3 comments

Comments

@odahcam
Copy link

odahcam commented Aug 23, 2018

The extension should look for a .phan/config.php inside each opened workspace instead of analysing only one folder.

The multi-project analysis is a very important feature, e.g.: I can't configure just one path in a company we work with 5+ projects at the same time.

@TysonAndre
Copy link
Owner

TysonAndre commented Aug 24, 2018

You can manually pass a list of directories to Phan.analyzedDirectory instead of a single string in the latest releases.

I agree that there should be an option like that to automatically start/stop based on open workspaces.

@odahcam
Copy link
Author

odahcam commented Aug 24, 2018

That's great, but like other plugins this is a common must have feature.

I'll try to give some help and maybe create a PR for that when I get the time. 🙂

@TysonAndre
Copy link
Owner

If the phan configuration is part of a project's workspace settings, it may be useful to specify that it's in ${whateverTheNameOfWorkspaceFolderIs}/subdirectory-with-phan-config (definitely not with that syntax). I haven't worked with workspace settings yet. (and that might be a problem if user settings had other folders)

https://github.com/Microsoft/vscode issue 2809 mentions that environment variables aren't possible yet in workspace settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants