-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkValidAnalyzedProjectDirectory vs --config-file #64
Comments
For instance, you can trick vscode-php-phan with an empty .phan/config.php file to load the external config.php. |
analyzedProjectDirectory supports an array of one or more project directories, so they can't all use the same --config-file. Adding So my plan to solve this would be |
The simplest solution would be a way to disable the checkValidAnalyzedProjectDirectory validation. "analyzedProjectDirectory" as an array is a nice feature. But in my case, I have the projects separated in its own space (not integrated into a VSCode workspace). So, I don't use it. Ideally, if analyzedProjectDirectory is an array, each project could have its own set of arguments. |
I could add an option to allow that (off by default) |
Cool. Great addition. |
Hi,
The extension checks if there is a config file in the defined phan.analyzedProjectDirectory (function checkValidAnalyzedProjectDirectory).
Phan supports the CLI argument -k/--config-file parameter to use an external config file. This option does not work in the extension and it is being ignored by the checkValidAnalyzedProjectDirectory validation.
Thanks, great extension!
The text was updated successfully, but these errors were encountered: