Problem
There are 12 suppressMessages(suppressWarnings(...)) call sites across the package (primarily in compile_acs_data.R, generate_codebook.R, table_registry.R, and auto_percent.R). These suppress ALL diagnostics, including potentially important ones:
- API rate-limit warnings from tidycensus
- Invalid variable code warnings
- Deprecation notices from dependency packages
- Geometry-related warnings from tigris/sf
This makes debugging production issues difficult since errors in upstream dependencies are silently swallowed.
Suggested approach
Audit each site and either:
- Replace with
withCallingHandlers() targeting specific known-noisy messages (e.g., tidycensus data source messages)
- Remove suppression entirely where the messages are useful
- Document why suppression is needed where it must remain
Context
Identified during code review. Most sites wrap tidycensus::load_variables() or tidycensus::get_acs() calls, which emit noisy but harmless messages about data source/year.
Problem
There are 12
suppressMessages(suppressWarnings(...))call sites across the package (primarily incompile_acs_data.R,generate_codebook.R,table_registry.R, andauto_percent.R). These suppress ALL diagnostics, including potentially important ones:This makes debugging production issues difficult since errors in upstream dependencies are silently swallowed.
Suggested approach
Audit each site and either:
withCallingHandlers()targeting specific known-noisy messages (e.g., tidycensus data source messages)Context
Identified during code review. Most sites wrap
tidycensus::load_variables()ortidycensus::get_acs()calls, which emit noisy but harmless messages about data source/year.