Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate alternate monitoring location identifier in to TADA_FindNearbySites #526

Open
8 tasks
hillarymarler opened this issue Sep 18, 2024 · 0 comments
Open
8 tasks
Labels
Future Improvement Minimum viable function complete, issue includes potential future improvements HOLD - waiting for WQX 3.0

Comments

@hillarymarler
Copy link
Collaborator

When alternate monitoring location identifiers are served by WQX 3.0 profiles, incorporate it into TADA_FindNearbySites to group monitoring locations already identified as groups by submitting orgs.

Reminders for TADA contributors addressing this issue:

New features and/or edits should include all the following work:

  • Create or edit the function/code.

  • Document all code using line/inline and/or multi-line/block comments
    to describe what is does.

  • Create or edit tests in tests/testthat folder to help prevent and/or
    troubleshoot potential future issues.

  • Create or edit the function documentation. Include working
    examples.

  • Update or add the new functionality to the appropriate vignette
    (or create new one).

  • If function/code edits made as part of this issue impact other
    functions in the package or functionality in the shiny app, ensure
    those are updated as well.

  • Run TADA_UpdateAllRefs(), TADA_UpdateExampleData(), styler::style_pkg(),
    devtools::document(), and devtools::check() and address any new notes or
    issues before creating a pull request.

  • Run more robust check for releases: devtools::check(manual = TRUE,
    remote = TRUE, incoming = TRUE)

@hillarymarler hillarymarler added Future Improvement Minimum viable function complete, issue includes potential future improvements Good First Issue Good issue for first time contributors HOLD - waiting for WQX 3.0 labels Sep 18, 2024
@cristinamullin cristinamullin removed the Good First Issue Good issue for first time contributors label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Future Improvement Minimum viable function complete, issue includes potential future improvements HOLD - waiting for WQX 3.0
Projects
None yet
Development

No branches or pull requests

2 participants