-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hard to read a reported value #109
Comments
@Tiehong , I am not able to reproduce your observation. The report file has columns that are space delimited. I am going to close this issue unless you are able to provide additional information. |
@MitchHeineman Interesting... It seems to me this is an artifact of the GUI framework. Does resizing the column eliminate the issue or are the preceding numbers actually appended to the Type field in the example you show? I will try to reproduce it on my end. |
Wouldn't making all the columns scientific format fix the issue? Then there will be a space. J1 JUNCTION 321741.00321741.00 0 11:54 5.72e+03 5.72e+03 0.000 |
It seems to me this is an issue that has been addressed with various columns at various times. We probably have to think a bit about how we implement it going forward so that it works for all fields. |
We loose some of the digits using scientific format but it should be a good solution for now. It seems the larger issue is the attempt to align the column names with the values for ease in reading the results, which is a good thing for users. |
I haven't looked at the code (besides, my native language is Fortran), and perhaps it already does this in places, but I'd suggest using floating point notation where values fit into the columns and scientific only for large values. In Fortran, this is generally a matter of using the G edit descriptor. Something like this? #include <stdio.h> Now I see there's a G edit descriptor in C as well, but you get the idea... |
Reopening ... Given that this issue is being reported at this late date, width overflow in report file tables can be regarded as an edge case. While the solution currently implemented, adopting the On the otherhand, simply providing padding like so, Therefore, to patch this bug, I prefer padding the fields with a space so they no longer run together in the event of a width overflow. No changes to table headers, the UI code, or the benchmark files is required. PR coming forthwith ... |
In the report file, it will be better if a space is added between columns. It is hard to read a value if it is concatenated with another one (see below). Model is also attached.
Node Inflow Summary
Node Type CFS CFS days hr:min 10^6 gal 10^6 gal Percent
J1 JUNCTION 321741.00321741.00 0 11:54 5.72e+03 5.72e+03 0.000
J10 JUNCTION 33302.29 33310.07 0 11:54 589 594 0.001
J11 JUNCTION 0.00 200.01 0 05:21 0 109 0.004
J12 JUNCTION 47138.83 47138.83 0 11:54 838 838 0.000
J13 JUNCTION 0.00 7.65 0 03:12 0 3.66 0.006
J14 JUNCTION 0.00 112.79 0 04:30 0 62.8 0.041
J15 JUNCTION 0.00 0.00 0 00:00 0 0 0.000 gal
J16 JUNCTION 0.00 333.99 0 11:33 0 169 0.002
J17 JUNCTION 0.00 13.12 0 03:12 0 2.38 0.040
J18 JUNCTION 0.00 1.12 0 03:13 0 0.00463 0.000
J19 JUNCTION 217559.28217620.62 0 11:54 3.78e+03 3.81e+03 0.000
J2 JUNCTION 805208.19805208.19 0 11:54 1.43e+04 1.43e+04 0.000
J20 JUNCTION 1059209.661059209.66 0 11:54 1.85e+04 1.85e+04 0.000
J21 JUNCTION 11396023.9111396023.91 0 11:54 2.02e+05 2.02e+05 0.000
J22 JUNCTION 742677.23742678.50 0 11:54 1.32e+04 1.32e+04 0.000
working_LymanDrainage.zip
The text was updated successfully, but these errors were encountered: