Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjustMultiplierPriceType and adjustResultMatrixPrice do not work for models with BasePriceType=="PUR" #183

Open
MoLi7 opened this issue Dec 3, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@MoLi7
Copy link
Collaborator

MoLi7 commented Dec 3, 2021

We recommend building USEEIO models with BasePriceType=="PRO", but the functions should give users flexibility to build PUR models then optionally adjust model results to PRO.
Thinking about refactoring these two functions to achieve the goal.
@WesIngwersen

@MoLi7 MoLi7 added the enhancement New feature or request label Dec 3, 2021
@MoLi7 MoLi7 added this to the v1.0 milestone Dec 3, 2021
@MoLi7 MoLi7 self-assigned this Dec 3, 2021
@WesIngwersen
Copy link
Collaborator

This ia a nice goal but not a simple task. It will require considerable evaluation and testing.

@MoLi7
Copy link
Collaborator Author

MoLi7 commented Dec 3, 2021

Save this till after v1.0?

@WesIngwersen WesIngwersen removed this from the v1.0 milestone Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants