Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve or drop aggregateResultMatrix #309

Open
WesIngwersen opened this issue Aug 6, 2024 · 1 comment · May be fixed by #316
Open

Improve or drop aggregateResultMatrix #309

WesIngwersen opened this issue Aug 6, 2024 · 1 comment · May be fixed by #316
Labels
enhancement New feature or request
Milestone

Comments

@WesIngwersen
Copy link
Collaborator

aggregateResultMatrixbyRow <- function (matrix, to_level, crosswalk) {

correct usage would be for example, with model being a model object already built and assume model is a summary level model (would also work for detail)

A_d_sector <- aggregateResultMatrix(model$A_d, "Sector", model$crosswalk)

But this is not well documented, no examples are given and inconsistent with other functions like adjustResultMatrixPrice() where one specifies the matrix like A_d and not having to pass model$A_d. and also having to pass the whole model$crosswalk is odd and then not clear what matrices can be passed... docs say "result matrix" but this actually fails for what are called result matrices like M and N that are not sector x sector.

@WesIngwersen WesIngwersen added the enhancement New feature or request label Aug 6, 2024
bl-young added a commit that referenced this issue Sep 4, 2024
@bl-young
Copy link
Collaborator

bl-young commented Sep 4, 2024

I've clarified the descriptions for this and aggregateResultMatrixbyRow() in a61fc47. One is designed to aggregate a result matrix (G or H) while the other is to aggregate a sector by sector result such as what comes out of calculateSectorPurchasedbySectorSourcedImpact()

@bl-young bl-young linked a pull request Sep 6, 2024 that will close this issue
@bl-young bl-young linked a pull request Sep 6, 2024 that will close this issue
@bl-young bl-young added this to the v1.7 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants