Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HEADLESS_MODE toggled via CLI parameter #32

Closed
jpahm opened this issue Oct 10, 2024 · 4 comments
Closed

Make HEADLESS_MODE toggled via CLI parameter #32

jpahm opened this issue Oct 10, 2024 · 4 comments
Assignees
@justi-lai
Labels
Good First Issue Good for newcomers L1 A task suitable for someone who is comfortable helping with basic issues.

Comments

@jpahm
Copy link
Contributor

jpahm commented Oct 10, 2024 •
edited
Loading

Currently, HEADLESS_MODE for the chromedp scrapers is set via the .env file. However, this is a bit annoying to have to edit in order to toggle between headless and non-headless mode, so this should be changed to a command-line flag like -headless which can be parsed by the main file.

Make sure the .env.template file is updated accordingly.
@jpahm jpahm added Good First Issue Good for newcomers L1 A task suitable for someone who is comfortable helping with basic issues. labels Oct 10, 2024
@justi-lai
Copy link
Contributor

Hey Josh, can I try taking this issue?

@jpahm
Copy link
Contributor Author

jpahm commented Oct 10, 2024

Hey Josh, can I try taking this issue?

Sure thing, all yours!

@justi-lai
Copy link
Contributor

Thanks!

@jpahm
Copy link
Contributor Author

jpahm commented Oct 21, 2024

Closed via #37

@jpahm jpahm closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justi-lai justi-lai

Labels
Good First Issue Good for newcomers L1 A task suitable for someone who is comfortable helping with basic issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpahm @justi-lai