Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "courses" aggregate endpoint to professor endpoint #230

Open
jpahm opened this issue Oct 23, 2024 · 4 comments · May be fixed by #234
Open

Add "courses" aggregate endpoint to professor endpoint #230

jpahm opened this issue Oct 23, 2024 · 4 comments · May be fixed by #234
Assignees
@mikehquan19
Labels
L2 A task suitable for someone who is comfortable implementing features.

Comments

@jpahm
Copy link
Contributor

jpahm commented Oct 23, 2024

Currently, it can be inconvenient and overcomplicated for our end users to perform some common aggregate operations such as getting all of a professor's courses.

As such, we should add the following endpoints which immediately aggregate and return matching professor's courses:

  • Query based: GET /professor/courses (allows for querying like the base professor endpoint)
  • ID specific: GET /professor/{professorId}/courses (gets courses only for a specific professor)
@jpahm jpahm added the L2 A task suitable for someone who is comfortable implementing features. label Oct 23, 2024
@jpahm jpahm changed the title Add "courses" endpoint to professor endpoint Add "courses" aggregate endpoint to professor endpoint Oct 23, 2024
@mikehquan19
Copy link
Contributor

Can I work on this? I want to practice querying the MongoDB database and building API a bit more.

@jpahm
Copy link
Contributor Author

jpahm commented Oct 26, 2024

Can I work on this? I want to practice querying the MongoDB database and building API a bit more.

You're more than welcome to!

@mikehquan19
Copy link
Contributor

Hi! I've made the pull request. Hope you will review it and give me feedback.

Thank you.

@jpahm
Copy link
Contributor Author

jpahm commented Oct 31, 2024

Thanks, I will review it shortly!

@mikehquan19 mikehquan19 mentioned this issue Nov 1, 2024
Open
@jpahm jpahm linked a pull request Nov 4, 2024 that will close this issue
Add courses aggregate endpoint to professor endpoint #234
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikehquan19 mikehquan19

Labels
L2 A task suitable for someone who is comfortable implementing features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add courses aggregate endpoint to professor endpoint mikehquan19/nebula-api
2 participants
@jpahm @mikehquan19