Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete link replies if no embed generated #255

Open
ericthelemur opened this issue Aug 4, 2024 · 1 comment
Open

Delete link replies if no embed generated #255

ericthelemur opened this issue Aug 4, 2024 · 1 comment
Labels
bug Something isn't working enhancement Improvement to existing command/feature

Comments

@ericthelemur
Copy link
Contributor

Currently apollo blindly replies to e.g. instagram links, but sometimes they are search or account links with no embed, so it's a wasted message.

Either

  • Improve the detection to avoid these cases
  • or delete the embed if no embed is actually generated by the 2nd one (or the original message has a better embed)
@ericthelemur ericthelemur added bug Something isn't working enhancement Improvement to existing command/feature labels Aug 4, 2024
@raven0034
Copy link

I imagine a fair bit of this can be dealt with using regex then use the second point as a fallback.

Also e.g. in the case of Twitter links, the Twitter embed, even when it is sometimes working, is worse than the fxtwitter alternative e.g. when there is a video attached to the tweet. ie worth considering on a platform by platform basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improvement to existing command/feature
Projects
None yet
Development

No branches or pull requests

2 participants