-
Notifications
You must be signed in to change notification settings - Fork 16
fix: use pydantic models for create index payloads #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PopescuTudor
wants to merge
1
commit into
main
Choose a base branch
from
fix/create-cgi-use-pydantic-models
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristipufu
reviewed
Oct 10, 2025
72d2555 to
a62d157
Compare
radu-mocanu
reviewed
Oct 10, 2025
radu-mocanu
reviewed
Oct 10, 2025
|
|
||
| if cron_expression: | ||
| data_source["indexer"] = { | ||
| data_source_dict["indexer"] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don t we create a model for this and add it as an optional member of DataSourceBase?
class Indexer(BaseModel):
model_config = ConfigDict(alias_generator=to_camel, populate_by_name=True)
cron_expression: str
time_zone_id: str
@model_validator(mode = 'before')
def validate():
... #we can even add a cron expression validator here
class BaseSourceConfig(BaseModel):
indexer: Optional[Indexer] = None
...
radu-mocanu
reviewed
Oct 10, 2025
|
|
||
| name: str = Field(description="Index name") | ||
| description: str = Field(default="", description="Index description") | ||
| data_source: Dict[str, Any] = Field( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let s use the DataSourceBase here
a62d157 to
a66458b
Compare
a66458b to
b533b12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
test:uipath-langchain
Triggers tests in the uipath-langchain-python repository
test:uipath-llamaindex
Triggers tests in the uipath-llamaindex-python repository
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.