Add configurable token storage and logout method #115
+73
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnaren23
reviewed
Oct 31, 2025
| sessionStorage.removeItem('uipath_sdk_oauth_context'); | ||
| sessionStorage.removeItem('uipath_sdk_code_verifier'); | ||
| } catch (error) { | ||
| console.warn('Failed to clear OAuth context from session storage', error); |
vnaren23
reviewed
Oct 31, 2025
| } | ||
|
|
||
| // Check if token is expired | ||
| if (this.isTokenExpired(tokenInfo)) { |
There was a problem hiding this comment.
Why not combine both conditions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localStorageandsessionStoragefor OAuth token storage, withsessionStorageas the secure default.logout()method to clear all authentication state.Motivation
Problem 1: Cross-Tab Token Persistence
With sessionStorage, OAuth tokens don't persist across browser tabs opened via
target="_blank"in modern browsers.Impact: Since sessionStorage isn’t shared across tabs, authentication tokens aren't available when a new page opens in a new tab, causing reauthentication or redirect issues.
Problem 2: SDK lacked a proper logout mechanism.