Secondary Roles with positive safety margin does not finish resolution until timeout is reached or resolution key is released

[firngrod]

The resolution is correct, it is just not reached until timeout is reached or some other key action triggers resolution after safety margin has passed. A wakeup for the resolution is simply never set.
I will fix this myself, just putting it here to not forget.

[firngrod]

Another one I just noticed in the code: Configured timeout action is ignored if

• Trigger On Release
• Timeout is reached after another key is pressed but not released
  In that case, it will always trigger as secondary.

[firngrod]

Another one gleaned from the code: With negative safety margin trigger on release, release doesn't trigger resolution while an action key is pressed, not until timeout or action key release. Again, the wakeup isn't scheduled.

All in all, the function is suffering from too much iterative development, and I'm in the process of overhauling it.

[kareltucek]

release doesn't trigger resolution while an action key is pressed, not until timeout or action key release

(I may easily be misunderstanding/missing some context, but...)

(Reality check: the margin is added to the time, so negative one should make the key resolve sooner assuming that we have an oracle, right?)

But we don't have an oracle, so it doesn't know that a key release is going to come within the next abs(safetyMargin), so it cannot resolve before it, right?

The only expected change in behavior is that once the release or timeout comes, the safety margin is taken into account when deciding the role.

Given this, the only possible change in behavior may be that you would expect it to resolve at timeout - safetyMargin, but that is not actual behavior change - it yields the same behavior one way or the other if you adjust the timeout.

[kareltucek]

Another one I just noticed in the code: Configured timeout action is ignored if

* Trigger On Release

* Timeout is reached after another key is pressed but not released
  In that case, it will always trigger as secondary.

It may be better to create separate topics about these.

What is the scenario here?

• press dual role key
• press a
• press b
• now timeout is reached?
• now you say that it resolves as secondary instead of the configured timeout action?

[firngrod]

a has secondary role. Timeout is large. Safety margin is negative. b is allowed to trigger secondary on a.

• a is pressed
• b is pressed
• a is released
• b is held for more than safety margin
• a does not resolve when safety margin runs out, but when b is released or timeout is reached

[firngrod]

I'm keeping this in one issue because as I said, I am overhauling the resolver. It's got a lot of small issues which will hopefully all be resolved. Most of them I only actually notice when I look closely at the code, so none are critical in and of themselves.

[firngrod]

Another one I just noticed in the code: Configured timeout action is ignored if

* Trigger On Release

* Timeout is reached after another key is pressed but not released
  In that case, it will always trigger as secondary.

It may be better to create separate topics about these.

What is the scenario here?

* press dual role key

* press a

* press b

* now timeout is reached?

* now you say that it resolves as secondary instead of the configured timeout action?

Correct, by the way.

[mhantsch]

Is the underlying issue also the reason why ifHold currently does not activate until I release the key?

graveTilde macro bound to the ` ~ key:

ifShortcut 1 exec quoteLong
ifHold exec quoteLong
holdKey graveAccentAndTilde

When I tap it, I get a grave accent. ✔️
When I combo it with 1, I immediately get the quoteLong result. ✔️
When I hold it, nothing happens until I release it. Then I get the quoteLong result. 🤔

I think it should resolve as soon as the timeout is reached. That has always been the behaviour, and that way I also get feedback when I have held the key long enough to activate quoteLong.

quoteLong just types two lines of triple backticks with an empty line in between, and places the cursor on the empty line, ready to have some code pasted into it:

tapKeySeq graveAccentAndTilde graveAccentAndTilde graveAccentAndTilde
tapKeySeq enter enter
tapKeySeq graveAccentAndTilde graveAccentAndTilde graveAccentAndTilde enter
tapKeySeq up up

[kareltucek]

No, ifHold implementation is separate from secondary roles, and is much simpler.

Given the description I would guess that I had missed placing there a wake timer.

[mhantsch]

I tried adding

set holdTimeout 350

to my init macro; didn't make any difference.

I am not using the new fingrod build; I am running one of the latest builds from master.

[kareltucek]

I will look into it at some point, but now I am pretty overwhelmed.

[mhantsch]

No, ifHold implementation is separate from secondary

OK, I'll create a separate issue then.

[mhantsch]

now I am pretty overwhelmed

Yes, I realise that you have a lot on your plate right now.

I will make sure my findings are recorded and can be followed up at an appropriate point in time -- by you or even someone else who can dig into the code.