Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disassembly and decompilation fails after renaming function #1428

Open
Archie-osu opened this issue Jul 7, 2023 · 4 comments · May be fixed by #1707
Open

Disassembly and decompilation fails after renaming function #1428

Archie-osu opened this issue Jul 7, 2023 · 4 comments · May be fixed by #1707
Labels
bug Something isn't working compiler Problems with the compiler decompiler Problems with the decompiler waiting for new compiler test This needs to be tested with the new Underanalyzer compiler

Comments

@Archie-osu
Copy link
Contributor

Describe the bug

Got it on video: http://www.youtube.com/watch?v=_p6gToWKurE

Reproducing steps

Step 1: Open a data.win file
Step 2: Define your own, unique function
Step 3: Rename the function
Step 4: Observe a decompiler / disassembler breakdown

Setup Details

  1. UndertaleModTool version: 0.5.1.0 (fa327ab)
  2. Operating system: Windows 10 Pro 22H2, 19045.3086
  3. GameMaker Game: Will You Snail (Sandbox Beta)
@Archie-osu Archie-osu added the bug Something isn't working label Jul 7, 2023
@Jacky720
Copy link
Contributor

Jacky720 commented Jul 7, 2023

Please try updating to the latest bleeding edge. This should have been fixed by #1351

@Archie-osu
Copy link
Contributor Author

This is on the latest bleeding edge release. The commit matches.

@Jacky720 Jacky720 linked a pull request Mar 5, 2024 that will close this issue
Draft
@Miepee Miepee added the decompiler Problems with the decompiler label Jun 1, 2024
@colinator27
Copy link
Member

This seems like a compiler bug that still affects the Underanalyzer decompiler fork - we should investigate if the struct function pruning affects this at all. I think the problem is that a function isn't getting deleted properly when renamed (or possibly when removed in any way).

@colinator27 colinator27 added the compiler Problems with the compiler label Jul 1, 2024
@colinator27 colinator27 added the waiting for new compiler test This needs to be tested with the new Underanalyzer compiler label Mar 9, 2025
@colinator27
Copy link
Member

This will likely be fixed with the new compiler, currently entering testing at #2056.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working compiler Problems with the compiler decompiler Problems with the decompiler waiting for new compiler test This needs to be tested with the new Underanalyzer compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Misc. function fixes Jacky720/UndertaleModTool
4 participants
@colinator27 @Jacky720 @Miepee @Archie-osu