Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML compiler missing static keyword #1917

Open
ChronoVortex opened this issue Sep 17, 2024 · 3 comments
Open

UML compiler missing static keyword #1917

ChronoVortex opened this issue Sep 17, 2024 · 3 comments
Labels
bug Something isn't working waiting for new compiler test This needs to be tested with the new Underanalyzer compiler

Comments

@ChronoVortex
Copy link

Describe the bug

Attempting to make changes to the decompiled gml_GlobalScript_scrScore code file in the latest Void War release throws the following error:

---------------------------
Compiler error
---------------------------
Errors parsing code when trying to compile modified "gml_GlobalScript_scrScore":



Expected assignment operator around line 440, column 16 (getAllCrewData).

Expected assignment operator around line 473, column 16 (getShipData).

Expected assignment operator around line 477, column 20 (getSysData).

Expected assignment operator around line 499, column 20 (getWeapons).

Unexpected token in expression around line 520, column 13.

Malformed assignment statement.

Expected assignment operator around line 522, ...
---------------------------
OK   
---------------------------

The code referenced by the error:
generate_score_data.txt

Reproducing steps

Fix struct keyword issue in #1916 as specified in this comment, then attempt to make modifications to the code and recompile.

Setup Details

  1. Latest from underanalyzer branch (8c5462c)
  2. Windows 10
  3. Void War Alpha Patch #​2 (https://tundra-interactive.itch.io/void-war)
@ChronoVortex ChronoVortex added the bug Something isn't working label Sep 17, 2024
@ChronoVortex
Copy link
Author

After messing with a few more functions, it seems like there may be something wrong with the way the compiler handles the static keyword, in particular when declaring a static variable and assigning a function to it

function someOuterFunction(argument0)
{
  static someInnerFunction = function(argument0)
  {
    return argument0;
  };
  return argument0;
}

@ChronoVortex
Copy link
Author

Confirming that the compiler is missing implementation for the static keyword

@ChronoVortex ChronoVortex changed the title Another UML compiler issue with Underanalyzer UML compiler missing static keyword Sep 18, 2024
@colinator27
Copy link
Member

Should be fixed as part of #2056.

@colinator27 colinator27 added the waiting for new compiler test This needs to be tested with the new Underanalyzer compiler label Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting for new compiler test This needs to be tested with the new Underanalyzer compiler
Projects
None yet
Development

No branches or pull requests

2 participants