Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"part_system_create_layer" compilation error in games made in a non-LTS GM (2023.8) #2027

Closed
amazeedaizee opened this issue Jan 25, 2025 · 2 comments
Labels
bug Something isn't working waiting for new compiler test This needs to be tested with the new Underanalyzer compiler

Comments

@amazeedaizee
Copy link

Describe the bug

part_system_create_layer decompiles normally when loading in scripts, however, if a call to the function contains three arguments, if the script is edited and has attempted to save, the compiler shows an error, even if the game is made with a version of GameMaker using this version of part_system_create_layer

Image

Image

Image
part_system_create_layer in the non-LTS GameMaker manual

It's a small error in retrospect, though I don't really want to touch these lines of the code, and the game calls part_system_create_layer a lot.

Reproducing steps

  1. Open a game made in GM 2023.8 (or any game made with a non-LTS of GameMaker)
  2. Open a script that contains a call to part_system_create_layer and decompiles it using three arguments (i.e. part_system_create_layer("layerID", false, ParticleSystem1)
  3. Attempt to edit and save the script, leaving the line(s) of code with part_system_create_layer untouched

Setup Details

  1. Bleeding Edge version 0.6.1.0 commit 3112518 (also attempted other versions like the one with Underanalyzer)
  2. Windows 11 Pro
  3. Needy Girl Overdose: Endless Nightmare
@amazeedaizee amazeedaizee added the bug Something isn't working label Jan 25, 2025
@colinator27 colinator27 added the waiting for new compiler test This needs to be tested with the new Underanalyzer compiler label Mar 9, 2025
@colinator27
Copy link
Member

This is likely fixed with the new compiler, currently entering testing at #2056.

@amazeedaizee
Copy link
Author

Just tested it using the artifacts from the listed pull request, seemed to fix it! Thanks for looking into this, really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting for new compiler test This needs to be tested with the new Underanalyzer compiler
Projects
None yet
Development

No branches or pull requests

2 participants