Zero-amount release reverts with `InsufficientBalance`

[KumaCrypto]

In TransferLib::release, when amount is 0 the call still reverts with InsufficientBalance(). However balance isn’t the problem here - it’s just a zero amount—so the revert can be confusing for users. We can move it to the separate if at the cost of extra bytecode size .

the-compact/src/lib/TransferLib.sol

Lines 52 to 55 in 0c72827

	if or(iszero(amount), gt(amount, fromBalance)) {
	mstore(0x00, 0xf4d678b8) // `InsufficientBalance()`.
	revert(0x1c, 0x04)
	}

the-compact/src/lib/TransferLib.sol

Lines 184 to 187 in 0c72827

	if or(iszero(amount), gt(amount, fromBalance)) {
	mstore(0x00, 0xf4d678b8) // `InsufficientBalance()`.
	revert(0x1c, 0x04)
	}

[0age]

the primary concern (assuming we have enough headroom in the bytecode) is actually the extra runtime cost of the added conditional

one option would be to apply the appropriate error selector based on whether or not the amount is zero; this could be performed branchlessly as well

[ultraviolet10]

Is this issue open to contributors? Open to experiment with what you've outlined @0age