Incorrect toString for org.jacodb.api.cfg.JcNewArrayExpr #206

lehvolk · lehvolk · commit 207c30674873 · 2023-12-05T14:49:26.000+03:00
diff --git a/jacodb-api/src/main/kotlin/org/jacodb/api/cfg/JcInst.kt b/jacodb-api/src/main/kotlin/org/jacodb/api/cfg/JcInst.kt
@@ -615,9 +615,9 @@ data class JcNewArrayExpr(
     companion object {
         private val regexToProcessDimensions = Regex("\\[(.*?)]")
 
-        private fun arrayTypeToStringWithDimensions(typeName: String, dimensions: List<JcValue>) {
+        private fun arrayTypeToStringWithDimensions(typeName: String, dimensions: List<JcValue>): String {
             var curDim = 0
-            regexToProcessDimensions.replace(typeName) {
+            return regexToProcessDimensions.replace(typeName) {
                 "[${dimensions.getOrNull(curDim++) ?: ""}]"
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -615,9 +615,9 @@ data class JcNewArrayExpr(`
`615`	`615`	`companion object {`
`616`	`616`	`private val regexToProcessDimensions = Regex("\\[(.*?)]")`
`617`	`617`
`618`		`- private fun arrayTypeToStringWithDimensions(typeName: String, dimensions: List<JcValue>) {`
	`618`	`+ private fun arrayTypeToStringWithDimensions(typeName: String, dimensions: List<JcValue>): String {`
`619`	`619`	`var curDim = 0`
`620`		`- regexToProcessDimensions.replace(typeName) {`
	`620`	`+ return regexToProcessDimensions.replace(typeName) {`
`621`	`621`	`"[${dimensions.getOrNull(curDim++) ?: ""}]"`
`622`	`622`	`}`
`623`	`623`	`}`