Migrate Mono APIs to CoreCLR-compatible APIs #640
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blies() - PackageImporter.cs: Add conditional compilation (line 136) - EditorToolbarLoader.cs: Add conditional compilation (line 135) - ReflectionUtility.cs: Add conditional compilation (line 40) - Added using UnityEngine.Assemblies with conditional directive - Maintains backward compatibility with older Unity versions
|
|
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## master #640 +/- ##
==========================================
- Coverage 35.57% 35.57% -0.01%
==========================================
Files 277 277
Lines 34892 34895 +3
==========================================
+ Hits 12413 12414 +1
- Misses 22479 22481 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
This PR replaces all instances of
MonoAPI calls withCoreCLR-compatible API calls in this repo, and is part of Epic SCP-1555.Further Context
Monoto usingCoreCLR.JIRA-ticket
Testing
Running the default job-suite. Please share if there are additional steps needed!