write test for PI group disband (requires changes in phpopenldaper)

Author: simonLeary42

resources/autoload.php

@@ -20,6 +20,7 @@
 require_once __DIR__ . "/lib/UnityWebhook.php";
 require_once __DIR__ . "/lib/UnityRedis.php";
 require_once __DIR__ . "/lib/UnityGithub.php";
+require_once __DIR__ . "/lib/exception/RedirectException.php";
 
 // run init script
 require __DIR__ . "/init.php";

resources/lib/UnitySite.php

@@ -10,7 +10,7 @@ public static function redirect($destination)
     {
         if ($_SERVER["PHP_SELF"] != $destination) {
             header("Location: $destination");
-            die("Redirect failed, click <a href='$destination'>here</a> to continue.");
+            throw new RedirectException("Redirect failed, click <a href='$destination'>here</a> to continue.");
         }
     }
 

resources/lib/exceptions/RedirectException.php

@@ -0,0 +1,7 @@
+<?php
+
+namespace UnityWebPortal\lib;
+
+class RedirectException extends \Exception
+{
+}

test/functional/PiDisbandTest.php

@@ -0,0 +1,56 @@
+<?php
+
+use PHPUnit\Framework\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
+use UnityWebPortal\lib\UnityUser;
+use UnityWebPortal\lib\UnityLDAP;
+use UnityWebPortal\lib\RedirectException;
+
+class PiDisbandTest extends TestCase {
+    static $requestUid;
+
+    public static function setUpBeforeClass(): void{
+        global $USER;
+        switchUser(...getNormalUser());
+        self::$requestUid = $USER->getUID();
+    }
+
+    private function disband()
+    {
+        // PI disband leads to redirect, redirect doesn't work during testing
+        try {
+            post(
+                __DIR__ . "/../../webroot/panel/pi.php",
+                ["form_name" => "disband"]
+            );
+        } catch (RedirectException $e) {}
+    }
+
+    public function testDisband()
+    {
+        global $USER, $SQL;
+        switchUser(...getUserIsPIHasNoMembersNoMemberRequests());
+        $pi = $USER;
+        $piGroup = $USER->getPIGroup();
+        $piGroup->requestGroup(true);
+        $piGroup->approveGroup();
+        $piGroupEntry = $piGroup->getLDAPPiGroup();
+        $piGroupAttributesBefore = $piGroupEntry->getAttributes();
+        error_log(json_encode($piGroupAttributesBefore, JSON_PRETTY_PRINT));
+        $piGroupName = $piGroup->getPIUID();
+        $this->assertTrue($piGroup->exists());
+        $this->assertEquals([$pi->getUID()], $piGroup->getGroupMemberUIDs());
+        $this->assertEmpty($piGroup->getRequests());
+        try {
+            $SQL->addRequest(self::$requestUid, $piGroupName);
+            $this->disband();
+            $this->assertFalse($piGroup->exists());
+            $this->assertEmpty($SQL->getRequests($piGroup->getPIUID()));
+        } finally {
+            $piGroupEntry->setAttributes($piGroupAttributesBefore);
+            if (!$piGroupEntry->write()) {
+                throw new Exception("Failed to recreate POSIX group $piGroupName");
+            }
+        }
+    }
+}

test/phpunit-bootstrap.php

@@ -14,6 +14,7 @@
 require_once __DIR__ . "/../resources/lib/UnityWebhook.php";
 require_once __DIR__ . "/../resources/lib/UnityRedis.php";
 require_once __DIR__ . "/../resources/lib/UnityGithub.php";
+require_once __DIR__ . "/../resources/lib/exception/RedirectException.php";
 
 global $HTTP_HEADER_TEST_INPUTS;
 $HTTP_HEADER_TEST_INPUTS = [