add page load tests, fix other tests (#280)

* add page load tests

* remove imports

* fix class name

* import DataProvider

* ...

* make require work for tests

* add dummy assertion

* use nonexistent user for new_account.php

* add missing switchUser

* update cache

Author: simonLeary42

test/functional/NewUserTest.php

@@ -94,7 +94,7 @@ private function approveGroup($uid)
     // does not remove user from PI groups
     private function ensureUserDoesNotExist()
     {
-        global $USER, $SQL, $LDAP;
+        global $USER, $SQL, $LDAP, $REDIS;
         $SQL->deleteRequestsByUser($USER->uid);
         if ($USER->exists()) {
             $org = $USER->getOrgGroup();
@@ -116,6 +116,7 @@ private function ensureUserDoesNotExist()
             $all_users_group->write();
             assert(!in_array($USER->uid, $all_users_group->getAttribute("memberuid")));
         }
+        $REDIS->removeCacheArray("sorted_users", "", $USER->uid);
     }
 
     private function ensureOrgGroupDoesNotExist()
@@ -126,24 +127,28 @@ private function ensureOrgGroupDoesNotExist()
             $org_group->delete();
             assert(!$org_group->exists());
         }
+        $REDIS->removeCacheArray("sorted_orgs", "", $SSO["org"]);
     }
 
     private function ensureUserNotInPIGroup(UnityGroup $pi_group)
     {
-        global $USER;
+        global $USER, $REDIS;
         if ($pi_group->userExists($USER)) {
             $pi_group->removeUser($USER);
             assert(!$pi_group->userExists($USER));
         }
+        $REDIS->removeCacheArray($pi_group->gid, "members", $USER->uid);
     }
 
     private function ensurePIGroupDoesNotExist()
     {
-        global $USER, $LDAP;
+        global $USER, $LDAP, $REDIS;
+        $gid = $USER->getPIGroup()->gid;
         if ($USER->getPIGroup()->exists()) {
-            $LDAP->getPIGroupEntry($USER->getPIGroup()->gid)->delete();
+            $LDAP->getPIGroupEntry($gid)->delete();
             assert(!$USER->getPIGroup()->exists());
         }
+        $REDIS->removeCacheArray("sorted_groups", "", $gid);
     }
 
     public function testCreateUserByJoinGoupByPI()
@@ -327,6 +332,7 @@ public function testCreateUserByCreateGroup()
             // $this->assertTrue($third_request_failed);
             $this->assertRequestedPIGroup(false);
         } finally {
+            switchUser(...$user_to_create_args);
             $this->ensureOrgGroupDoesNotExist();
             $this->ensurePIGroupDoesNotExist();
             $this->ensureUserDoesNotExist();

test/functional/PageLoadTest.php

@@ -0,0 +1,35 @@
+<?php
+
+use PHPUnit\Framework\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
+
+class PageLoadTest extends TestCase
+{
+    public static function provider()
+    {
+        $admin = getAdminUser();
+        $nonexistent_user = getNonExistentUser();
+        $normal_user = getNormalUser();
+        $pi = getUserIsPIHasNoMembersNoMemberRequests();
+        return [
+            [$admin, __DIR__ . "/../../webroot/admin/pi-mgmt.php"],
+            [$admin, __DIR__ . "/../../webroot/admin/user-mgmt.php"],
+            [$admin, __DIR__ . "/../../webroot/admin/content.php"],
+            [$admin, __DIR__ . "/../../webroot/admin/notices.php"],
+            [$nonexistent_user, __DIR__ . "/../../webroot/panel/new_account.php"],
+            [$normal_user, __DIR__ . "/../../webroot/panel/account.php"],
+            [$normal_user, __DIR__ . "/../../webroot/panel/groups.php"],
+            [$normal_user, __DIR__ . "/../../webroot/panel/support.php"],
+            [$pi, __DIR__ . "/../../webroot/panel/pi.php"],
+        ];
+    }
+
+    #[DataProvider("provider")]
+    public function testLoadPage($user, $path)
+    {
+        global $USER, $SSO, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK;
+        switchuser(...$user);
+        http_get($path);
+        $this->assertTrue(true); // assert there were no errors
+    }
+}

webroot/panel/support.php

@@ -1,6 +1,6 @@
 <?php
 
-require "../../resources/autoload.php";
+require_once __DIR__ . "/../../resources/autoload.php";
 
 include $LOC_HEADER;
 ?>