treat IDnumbers 0-99 as in-use (#270)

simonLeary42 · web-flow · commit 25eadb479851 · 2025-07-11T09:47:32.000-04:00
diff --git a/resources/lib/UnityLDAP.php b/resources/lib/UnityLDAP.php
@@ -163,8 +163,9 @@ public function getNextOrgGIDNumber($UnitySQL)
 
     private function IDNumInUse($id)
     {
-        // id reserved for debian packages
-        if (($id >= 100 && $id <= 999) || ($id >= 60000 && $id <= 64999)) {
+        // 0-99 are probably going to be used for local system accounts instead of LDAP accounts
+        // 100-999, 60000-64999 are reserved for debian packages
+        if (($id <= 999) || ($id >= 60000 && $id <= 64999)) {
             return true;
         }
         $users = $this->userOU->getChildrenArray([], true);

Original file line number	Diff line number	Diff line change
`@@ -163,8 +163,9 @@ public function getNextOrgGIDNumber($UnitySQL)`
`163`	`163`
`164`	`164`	`private function IDNumInUse($id)`
`165`	`165`	`{`
`166`		`- // id reserved for debian packages`
`167`		`- if (($id >= 100 && $id <= 999) \|\| ($id >= 60000 && $id <= 64999)) {`
	`166`	`+ // 0-99 are probably going to be used for local system accounts instead of LDAP accounts`
	`167`	`+ // 100-999, 60000-64999 are reserved for debian packages`
	`168`	`+ if (($id <= 999) \|\| ($id >= 60000 && $id <= 64999)) {`
`168`	`169`	`return true;`
`169`	`170`	`}`
`170`	`171`	`$users = $this->userOU->getChildrenArray([], true);`