handle github keys api properly

Author: simonLeary42

resources/lib/UnitySite.php

@@ -36,15 +36,16 @@ public static function getGithubKeys($username)
         curl_setopt($curl, CURLOPT_URL, $url);
         curl_setopt($curl, CURLOPT_RETURNTRANSFER, 1);
         curl_setopt($curl, CURLOPT_HTTPHEADER, $headers);
-        $output = json_decode(curl_exec($curl), true);
+        $keys = json_decode(curl_exec($curl), false);
         curl_close($curl);
 
-        $out = array();
-        foreach ($output as $value) {
-            array_push($out, $value["key"]);
+        // normally returns array of objects each with a ->key attribute
+        // if bad URL or no such user, returns status=404 object
+        // if no keys, returns []
+        if ((!is_array($keys)) || (count($keys) == 0)) {
+            return [];
         }
-
-        return $out;
+        return array_map(function($x){return $x->key;}, $keys);
     }
 
     public static function testValidSSHKey($key_str)

webroot/panel/account.php

@@ -38,9 +38,6 @@
                     break;
                 case "github":
                     $gh_user = $_POST["gh_user"];
-                    if (empty($gh_user)) {
-                        break;
-                    }
                     $keys = UnitySite::getGithubKeys($gh_user);
                     foreach ($keys as $key) {
                         if (UnitySite::testValidSSHKey($key)) {