Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim multiple consecutive spaces in text #883

Open
JohnVeness opened this issue Oct 20, 2022 · 2 comments
Open

Trim multiple consecutive spaces in text #883

JohnVeness opened this issue Oct 20, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@JohnVeness
Copy link

JohnVeness commented Oct 20, 2022

Describe the bug
SeriesGuide displays double-spaces in episode descriptions as wider than single-spaces, unlike the TMDB site.

Screenshots
SeriesGuide episode with a double space between sentences:
Screenshot_20221020-192938

Firefox/TMDB view of same episode - double space is not visible:
Screenshot_20221020-192952

For comparison, SeriesGuide episode with a single space between sentences:
Screenshot_20221020-193018

Firefox/TMDB view of same episode:
Screenshot_20221020-193033

Smartphone (please complete the following information):

  • Device: FxTec Pro1
  • OS: Android 9.0
  • Browser: Firefox 106.1.0
  • SeriesGuide Version: 65.0.5

Additional context
I have been editing descriptions on TMDB to remove double-spaces where I find them, but given that they don't appear on that website (unless in editing mode), this is quite tricky!

It seems TMDB renders spaces in the "normal" HTML manner, where multiple consecutive spaces are reduced down to one. It seems SeriesGuide is rendering them as if they are " " (I haven't actually checked SeriesGuide's code on this).

Given that TMDB is the data source, I think SeriesGuide should match the TMDB rendering rather than the other way round (that is, I'm not minded to suggest TMDB change so that they start displaying multiple spaces when present). In other words, I think SeriesGuide should trim double-spaces (and presumably any multiple number of spaces) within descriptions down to just one, or not replace them with " ", or whatever the cause is for this issue.

I haven't checked if the same problem happens in other fields, such as episode titles, season titles, season descriptions, so you might want to check that.

@JohnVeness JohnVeness added the bug Something isn't working label Oct 20, 2022
@UweTrottmann
Copy link
Owner

Thanks for the detailed report! If it's easy to do I'll do it. But my experience here is limited. I'm not sure if just removing all double spaces does lead to side effects in some languages (right now I could not think of any).

@UweTrottmann UweTrottmann added enhancement New feature or request and removed bug Something isn't working labels Nov 10, 2022
@JohnVeness
Copy link
Author

Thanks. Yes, I wouldn't want there to be bad side-effects.

Given that a summary of my report is "render text the same as the TMDB website does", maybe you can reach out to some contacts there? Maybe they can show any code (or pseudocode) they use for processing text before it is output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants