Slight refactor

Author: J-Fields

src/actions/base.ts

@@ -11,7 +11,7 @@ import { isLiteralMode, unmapLiteral } from '../configuration/langmap';
 export abstract class BaseAction implements IBaseAction {
   abstract readonly actionType: ActionType;
 
-  public name = '';
+  public readonly name: string | undefined;
 
   /**
    * If true, the cursor position will be added to the jump list on completion.
@@ -204,14 +204,12 @@ export abstract class BaseCommand extends BaseAction {
 
     const resultingCursors: Cursor[] = [];
 
-    const cursorsToIterateOver = vimState.cursors
-      .map((x) => new Cursor(x.start, x.stop))
-      .sort((a, b) =>
-        a.start.line > b.start.line ||
-        (a.start.line === b.start.line && a.start.character > b.start.character)
-          ? 1
-          : -1,
-      );
+    const cursorsToIterateOver = [...vimState.cursors].sort((a, b) =>
+      a.start.line > b.start.line ||
+      (a.start.line === b.start.line && a.start.character > b.start.character)
+        ? 1
+        : -1,
+    );
 
     let cursorIndex = 0;
     for (const { start, stop } of cursorsToIterateOver) {

src/actions/commands/join.ts

@@ -114,14 +114,12 @@ class ActionJoin extends BaseCommand {
   }
 
   public override async execCount(position: Position, vimState: VimState): Promise<void> {
-    const cursorsToIterateOver = vimState.cursors
-      .map((x) => new Cursor(x.start, x.stop))
-      .sort((a, b) =>
-        a.start.line > b.start.line ||
-        (a.start.line === b.start.line && a.start.character > b.start.character)
-          ? 1
-          : -1,
-      );
+    const cursorsToIterateOver = [...vimState.cursors].sort((a, b) =>
+      a.start.line > b.start.line ||
+      (a.start.line === b.start.line && a.start.character > b.start.character)
+        ? 1
+        : -1,
+    );
 
     const resultingCursors: Cursor[] = [];
     for (const [idx, { start, stop }] of cursorsToIterateOver.entries()) {

src/actions/types.d.ts

@@ -4,7 +4,7 @@ import type { VimState } from '../state/vimState';
 export type ActionType = 'command' | 'motion' | 'operator' | 'number';
 
 export interface IBaseAction {
-  name: string;
+  readonly name: string | undefined;
   readonly actionType: ActionType;
   readonly isJump: boolean;
   readonly createsUndoPoint: boolean;