Small refactor

Author: J-Fields

src/cmd_line/commands/vscode.ts

@@ -1,5 +1,4 @@
 import { VimError } from '../../error';
-import { StatusBar } from '../../statusBar';
 import * as vscode from 'vscode';
 import { VimState } from '../../state/vimState';
 import { ExCommand } from '../../vimscript/exCommand';
@@ -10,18 +9,17 @@ export class VsCodeCommand extends ExCommand {
     .then(all)
     .map((command) => new VsCodeCommand(command));
 
-  private command?: string;
+  private command: string;
 
-  public constructor(command?: string) {
+  public constructor(command: string) {
     super();
     this.command = command;
+    if (!this.command) {
+      throw VimError.ArgumentRequired();
+    }
   }
 
   async execute(vimState: VimState): Promise<void> {
-    if (!this.command) {
-      StatusBar.displayError(vimState, VimError.ArgumentRequired());
-      return;
-    }
     await vscode.commands.executeCommand(this.command);
   }
 }

test/vimscript/exCommandParse.test.ts

@@ -43,6 +43,7 @@ import { VimError } from '../../src/error';
 import { EvalCommand } from '../../src/cmd_line/commands/eval';
 import { EchoCommand } from '../../src/cmd_line/commands/echo';
 import { Expression } from '../../src/vimscript/expression/types';
+import { VsCodeCommand } from '../../src/cmd_line/commands/vscode';
 
 function exParseTest(input: string, parsed: ExCommand) {
   test(input, () => {
@@ -800,6 +801,14 @@ suite('Ex command parsing', () => {
     );
   });
 
+  suite(':vscode', () => {
+    exParseTest(
+      ':vscode editor.action.commentLine',
+      new VsCodeCommand('editor.action.commentLine'),
+    );
+    exParseFails(':vscode', VimError.ArgumentRequired());
+  });
+
   suite(':y[ank]', () => {
     exParseTest(':y', new YankCommand({ register: undefined, count: undefined }));
     exParseTest(':y a', new YankCommand({ register: 'a', count: undefined }));