Fix r in Visual mode with multiple cursors

Author: J-Fields

src/actions/commands/actions.ts

@@ -1363,9 +1363,6 @@ export class ActionReplaceCharacter extends BaseCommand {
 class ActionReplaceCharacterVisual extends BaseCommand {
   modes = [Mode.Visual, Mode.VisualLine];
   keys = ['r', '<character>'];
-  override runsOnceForEveryCursor() {
-    return false;
-  }
   override createsUndoPoint = true;
 
   public override async exec(position: Position, vimState: VimState): Promise<void> {
@@ -1443,9 +1440,6 @@ class ActionReplaceCharacterVisual extends BaseCommand {
 class ActionReplaceCharacterVisualBlock extends BaseCommand {
   modes = [Mode.VisualBlock];
   keys = ['r', '<character>'];
-  override runsOnceForEveryCursor() {
-    return false;
-  }
   override createsUndoPoint = true;
 
   public override async exec(position: Position, vimState: VimState): Promise<void> {

test/multicursor.test.ts

@@ -69,6 +69,29 @@ suite('Multicursor', () => {
     });
   });
 
+  suite('Replace', () => {
+    newTest({
+      title: 'r (Normal mode)',
+      start: ['|cat', 'c|at', 'ca|t'],
+      keysPressed: 'rX',
+      end: ['|Xat', 'c|Xt', 'ca|X'],
+    });
+
+    newTest({
+      title: 'r (Visual mode)',
+      start: ['|cat', 'c|at', 'ca|t'],
+      keysPressed: 've' + 'rX',
+      end: ['|XXX', 'c|XX', 'ca|X'],
+    });
+
+    newTest({
+      title: 'r (VisualBlock mode)',
+      start: ['|ca|t', 'cat', 'cat'],
+      keysPressed: '<C-v>jj' + 'rX',
+      end: ['|Xa|X', 'XaX', 'XaX'],
+    });
+  });
+
   test('can add multiple cursors below', async () => {
     await modeHandler.handleMultipleKeyEvents('i11\n22'.split(''));
     await modeHandler.handleMultipleKeyEvents(['<Esc>', 'g', 'g']);