Skip to content

Commit 08913ab

Browse files
Merge pull request #1275 from laymonage/base-vwsexception
Create base VWSException for erroneous responses from VWS
2 parents 8e8563e + 79d1854 commit 08913ab

File tree

6 files changed

+140
-269
lines changed

6 files changed

+140
-269
lines changed

docs/source/conf.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ def _custom_warning_handler(msg: str, *args: Iterable, **kwargs: Dict) -> None:
9797
# Requests documentation exposes ``requests.Response``, not
9898
# ``requests.models.response``.
9999
('py:class', 'requests.models.Response'),
100+
('py:class', 'requests.exceptions.ConnectionError'),
100101
]
101102

102103
html_show_copyright = False

docs/source/exceptions.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,6 @@ Exceptions
33

44
.. automodule:: vws.exceptions
55
:members:
6+
:show-inheritance:
7+
:inherited-members: Exception
8+
:exclude-members: errno, filename, filename2, strerror

src/vws/_result_codes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def raise_for_result_code(
4949
result_code = response.json()['result_code']
5050
except json.decoder.JSONDecodeError as exc:
5151
assert 'Oops' in response.text
52-
raise UnknownVWSErrorPossiblyBadName() from exc
52+
raise UnknownVWSErrorPossiblyBadName(response=response) from exc
5353

5454
if result_code == expected_result_code:
5555
return

0 commit comments

Comments
 (0)