Skip to content

Commit 7a5cc1c

Browse files
Merge pull request #1286 from VWS-Python/bump-reqs
Bump isort
2 parents b8c9f42 + 4760eff commit 7a5cc1c

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

Makefile

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,10 @@ lint: \
2424
yapf
2525

2626
.PHONY: fix-lint
27-
fix-lint:
28-
# Move imports to a single line so that autoflake can handle them.
29-
# See https://github.com/myint/autoflake/issues/8.
30-
# Then later we put them back.
31-
isort --force-single-line --recursive --apply
32-
$(MAKE) autoflake
33-
$(MAKE) fix-yapf
34-
isort --recursive --apply
27+
fix-lint: \
28+
autoflake \
29+
fix-yapf \
30+
fix-isort
3531

3632
.PHONY: docs
3733
docs:

dev-requirements.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ flake8-commas==2.0.0 # Require silicon valley commas
1414
flake8-quotes==3.2.0 # Require single quotes
1515
flake8==3.8.3 # Lint
1616
freezegun==0.3.15
17-
isort==4.3.21 # Lint imports
17+
isort==5.4.2 # Lint imports
1818
mypy==0.782 # Type checking
1919
pip_check_reqs==2.1.1
2020
pydocstyle==5.1.0 # Lint docstrings
2121
pyenchant==3.1.1 # Bindings for a spellchecking sytem
2222
pygithub==1.53
23-
pylint==2.5.3 # Lint
23+
pylint==2.6.0 # Lint
2424
pyroma==2.6 # Packaging best practices checker
2525
pytest-cov==2.10.1 # Measure code coverage
2626
pytest==6.0.1 # Test runners

lint.mk

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,11 @@ flake8:
3636

3737
.PHONY: isort
3838
isort:
39-
isort --recursive --check-only
39+
isort --check-only .
40+
41+
.PHONY: fix-isort
42+
fix-isort:
43+
isort .
4044

4145
.PHONY: pip-extra-reqs
4246
pip-extra-reqs:

src/vws/vws.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -338,8 +338,8 @@ def decorated() -> None:
338338

339339
try:
340340
decorated()
341-
except FunctionTimedOut:
342-
raise TargetProcessingTimeout
341+
except FunctionTimedOut as exc:
342+
raise TargetProcessingTimeout from exc
343343

344344
def list_targets(self) -> List[str]:
345345
"""

0 commit comments

Comments
 (0)