fix(feedback): address 3 self-review findings

1. **webbrowser.open return value silently dropped on headless boxes**
   The command printed "Opening GitHub in your browser..." and exited 0
   even when webbrowser.open returned False (no GUI, no $BROWSER, CI
   runner, container without DISPLAY). Now we capture the return value,
   surface "no browser available — copy the URL above" to stderr, and
   only print "Opened GitHub in your browser." after a confirmed True
   return.

2. **_openkb_version was the third copy of the same logic**
   openkb/__init__.py exports __version__ via importlib.metadata with
   fallback "0.0.0+unknown"; openkb/agent/chat.py wraps it as
   _openkb_version(); cli.py was re-implementing it with fallback
   "unknown" — already drifted. Replaced with the same one-liner used
   in chat.py: `from openkb import __version__; return __version__`.
   Now all three call sites agree.

3. **type prompt hung in non-TTY contexts (regression of PR #48)**
   PR #48 introduced _stdin_is_tty() specifically because adding a
   prompt without a TTY check broke automation pipelines. PR #53's
   second prompt (asking for feedback type) repeated the same pattern.
   Now it skips the prompt when stdin isn't a TTY and falls through to
   `--type other`. Pipes / CI work without flags now:

     echo "..." | openkb feedback "msg"   # works, type=other, no label

4 new regression tests:
   - test_feedback_skips_type_prompt_when_stdin_is_not_a_tty
   - test_feedback_warns_when_webbrowser_open_returns_false
   - test_feedback_confirms_when_webbrowser_open_succeeds
   - test_openkb_version_helper_matches_package_version

331 tests pass (327 prior + 4 new).

Author: KylinMountain

openkb/cli.py

@@ -1150,15 +1150,15 @@ def status(ctx):
 
 
 def _openkb_version() -> str:
-    """Return the installed openkb package version, or 'unknown' if it
-    can't be resolved (e.g. running from an editable checkout that isn't
-    on PYTHONPATH as a distribution).
+    """Return the installed openkb package version.
+
+    Delegates to ``openkb.__version__`` so the chat REPL, feedback issue
+    body, and any future caller all surface the same fallback string
+    (``0.0.0+unknown`` from ``openkb/__init__.py``). Mirrors
+    ``openkb.agent.chat._openkb_version``.
     """
-    try:
-        from importlib.metadata import version
-        return version("openkb")
-    except Exception:
-        return "unknown"
+    from openkb import __version__
+    return __version__
 
 
 def _collect_feedback_diagnostics(ctx) -> dict[str, str]:
@@ -1253,13 +1253,20 @@ def feedback(ctx, message, feedback_type, print_url, no_diagnostics):
         return
 
     if feedback_type is None:
-        feedback_type = click.prompt(
-            "Type",
-            default="other",
-            type=click.Choice(_FEEDBACK_TYPES),
-            show_default=True,
-            show_choices=True,
-        )
+        # Skip the prompt in non-TTY contexts (CI / piped stdin) so
+        # ``echo "msg" | openkb feedback`` doesn't hang on the second
+        # prompt after consuming all piped input for the message body.
+        # Mirrors the ``_stdin_is_tty()`` gate added in PR #48.
+        if _stdin_is_tty():
+            feedback_type = click.prompt(
+                "Type",
+                default="other",
+                type=click.Choice(_FEEDBACK_TYPES),
+                show_default=True,
+                show_choices=True,
+            )
+        else:
+            feedback_type = "other"
 
     diagnostics = {} if no_diagnostics else _collect_feedback_diagnostics(ctx)
     url = _build_feedback_url(message, feedback_type, diagnostics)
@@ -1268,14 +1275,25 @@ def feedback(ctx, message, feedback_type, print_url, no_diagnostics):
         click.echo(url)
         return
 
-    click.echo("Opening GitHub in your browser to file the issue.")
-    click.echo("If nothing happens, copy this URL into a browser yourself:")
+    click.echo("Copy this URL into a browser if the auto-open below fails:")
     click.echo(f"  {url}")
 
     import webbrowser
     try:
-        webbrowser.open(url)
+        opened = webbrowser.open(url)
     except Exception as exc:
         # webbrowser.open rarely raises but be defensive — the printed URL
         # above is the fallback path.
         click.echo(f"  (browser auto-open failed: {exc})", err=True)
+        return
+
+    # ``webbrowser.open`` returns False on headless boxes (no GUI, no
+    # ``BROWSER`` env) without raising. Without this check we'd silently
+    # print "Opened" and the user would think the issue was filed.
+    if opened:
+        click.echo("Opened GitHub in your browser.")
+    else:
+        click.echo(
+            "  (no browser available — copy the URL above to file the issue)",
+            err=True,
+        )

tests/test_feedback.py

@@ -195,7 +195,8 @@ def test_feedback_no_diagnostics_strips_block_from_body():
 def test_feedback_prompts_for_type_when_not_given_via_flag():
     """If --type isn't on the command line, prompt the user."""
     runner = CliRunner()
-    with patch("webbrowser.open") as mock_open:
+    with patch("webbrowser.open") as mock_open, \
+         patch("openkb.cli._stdin_is_tty", return_value=True):
         result = runner.invoke(
             cli, ["feedback", "--print-url", "missing-type prompt test"],
             input="feature\n",
@@ -205,3 +206,65 @@ def test_feedback_prompts_for_type_when_not_given_via_flag():
     # The URL should be tagged with the chosen type (mapped to 'enhancement').
     url_line = [ln for ln in result.output.splitlines() if "issues/new" in ln][-1]
     assert "labels=enhancement" in url_line
+
+
+# ---------------------------------------------------------------------------
+# Regressions from the self-review on PR #53
+# ---------------------------------------------------------------------------
+
+
+def test_feedback_skips_type_prompt_when_stdin_is_not_a_tty():
+    """In CI / piped contexts the second prompt would hang or abort
+    confusingly — the command must fall through to a default."""
+    runner = CliRunner()
+    with patch("webbrowser.open"), \
+         patch("openkb.cli._stdin_is_tty", return_value=False):
+        result = runner.invoke(
+            cli, ["feedback", "--print-url", "non-tty feedback"],
+        )
+
+    assert result.exit_code == 0, result.output
+    # Non-TTY → falls back to "other", which has no label param
+    url_line = [ln for ln in result.output.splitlines() if "issues/new" in ln][-1]
+    assert "labels=" not in url_line
+    # And the title should NOT have a type prefix
+    assert "%5Bother%5D" not in url_line  # urlencoded "[other]"
+
+
+def test_feedback_warns_when_webbrowser_open_returns_false():
+    """`webbrowser.open` returns False on headless boxes without raising —
+    the command must surface that to the user, not silently pretend
+    success."""
+    runner = CliRunner()
+    with patch("webbrowser.open", return_value=False) as mock_open:
+        result = runner.invoke(
+            cli, ["feedback", "--type", "bug", "headless test"],
+        )
+
+    assert result.exit_code == 0, result.output
+    mock_open.assert_called_once()
+    # The success-confirmation message must NOT appear
+    assert "Opened GitHub in your browser" not in result.output
+    # The user must see a clear "no browser available" indication
+    assert "no browser available" in result.output
+
+
+def test_feedback_confirms_when_webbrowser_open_succeeds():
+    runner = CliRunner()
+    with patch("webbrowser.open", return_value=True):
+        result = runner.invoke(
+            cli, ["feedback", "--type", "bug", "happy path"],
+        )
+
+    assert result.exit_code == 0, result.output
+    assert "Opened GitHub in your browser" in result.output
+
+
+def test_openkb_version_helper_matches_package_version():
+    """`_openkb_version` in cli.py must delegate to `openkb.__version__`
+    so the chat REPL and the feedback issue body never disagree on the
+    fallback string."""
+    from openkb import __version__
+    from openkb.cli import _openkb_version
+
+    assert _openkb_version() == __version__