Commit 2d7d1cd
committed
fix(skill): drop parallel_tool_calls=False from tool-less eval agents
The eval-set generator, trigger grader, and coverage grader have no
tools — they only produce text. OpenAI's API rejects
`parallel_tool_calls` when `tools` is unset:
Invalid value for 'parallel_tool_calls': 'parallel_tool_calls' is
only allowed when 'tools' are specified.
`skill eval` would die at the very first LLM call, before any prompt
was graded. Tests masked it because they patch `Runner.run` and never
hit the LiteLLM layer.
Fix: stop passing `model_settings=ModelSettings(parallel_tool_calls=False)`
on those three agents — the flag is both invalid and meaningless when
the agent has zero tools to parallelise. `ModelSettings` is no longer
referenced anywhere in this module, so the import is dropped too.
Pre-existing bug carried over from the original evaluator design; this
is the first time anyone has run `skill eval` end-to-end against a
real LLM (everything else mocks Runner.run).1 parent ea63a33 commit 2d7d1cd
1 file changed
Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
43 | 42 | | |
44 | 43 | | |
45 | 44 | | |
| |||
207 | 206 | | |
208 | 207 | | |
209 | 208 | | |
210 | | - | |
211 | 209 | | |
212 | 210 | | |
213 | 211 | | |
| |||
266 | 264 | | |
267 | 265 | | |
268 | 266 | | |
269 | | - | |
270 | 267 | | |
271 | 268 | | |
272 | 269 | | |
| |||
315 | 312 | | |
316 | 313 | | |
317 | 314 | | |
318 | | - | |
319 | 315 | | |
320 | 316 | | |
321 | 317 | | |
| |||
0 commit comments