chore: clean up CodeQL py/* quality alerts (unused-import, unused-local-variable, empty-except)

Three CodeQL Code Quality rules cleared in one pass:

1. **py/unused-import** (33 fixes) — `ruff check --select F401 --fix`.
   4 in openkb/ (production code, all partial-unused where the line
   keeps the names actually used): Console at chat.py:341, SCHEMA_MD
   at linter.py:11, ItemHelpers at query.py:116, field at converter.py:6.
   29 in tests/ — leftover `import pytest`, `from pathlib import Path`,
   and unused mock classes from test scaffolding.

2. **py/unused-local-variable** (5 fixes) — all in tests/:
   - tests/test_add_command.py:72, 86 — `result = runner.invoke(...)`
     captured but only mock-call assertions matter; dropped the binding.
   - tests/test_add_command.py:122 — `as mock_conv` never referenced;
     removed the alias from the with-patch.
   - tests/test_lint.py:197, 210 — `wiki = _make_wiki(tmp_path)` where
     the helper's side effect (creating the dir tree) is what matters;
     dropped the binding, kept the call.

3. **py/empty-except** (2 fixes) — both in openkb/agent/tools.py
   inside `parse_pages`. The `except ValueError: pass` blocks were
   intentionally tolerating malformed segments in user-supplied page
   specs ("3-5,7,foo"). Replaced with `contextlib.suppress(ValueError)`,
   which signals the intent explicitly and CodeQL no longer flags.

Total: 40 quality alerts → 0. All 329 tests still pass. No behavior
change.

References:
- https://github.com/VectifyAI/OpenKB/security/quality/rules/py/unused-import
- https://github.com/VectifyAI/OpenKB/security/quality/rules/py/unused-local-variable
- https://github.com/VectifyAI/OpenKB/security/quality/rules/py/empty-except

(py/mixed-returns and py/multiple-definition: both 0 hits in the
current codebase, no fixes needed.)

Author: KylinMountain

openkb/agent/chat.py

@@ -338,7 +338,6 @@ async def _run_turn(
     need_blank_before_text = False
 
     if use_color and not raw:
-        from rich.console import Console
         from rich.live import Live
 
         console = _make_rich_console()

openkb/agent/linter.py

@@ -8,7 +8,7 @@
 from openkb.agent.tools import list_wiki_files, read_wiki_file
 
 MAX_TURNS = 50
-from openkb.schema import SCHEMA_MD, get_agents_md
+from openkb.schema import get_agents_md
 
 _LINTER_INSTRUCTIONS_TEMPLATE = """\
 You are OpenKB's semantic lint agent. Your job is to audit the wiki

openkb/agent/query.py

@@ -113,7 +113,7 @@ async def run_query(
         The agent's final answer as a string.
     """
     import sys
-    from agents import RawResponsesStreamEvent, RunItemStreamEvent, ItemHelpers
+    from agents import RawResponsesStreamEvent, RunItemStreamEvent
     from openai.types.responses import ResponseTextDeltaEvent
     from openkb.config import load_config
 

openkb/agent/tools.py

@@ -6,6 +6,7 @@
 """
 from __future__ import annotations
 
+import contextlib
 import json as _json
 from pathlib import Path
 
@@ -71,21 +72,19 @@ def parse_pages(pages: str) -> list[int]:
             segments = part.split("-")
             # Re-join to handle leading negatives: segments[0] may be empty
             # if part starts with "-".  We just try to parse start/end.
-            try:
+            # Silently skip malformed segments — parse_pages is a tolerant
+            # parser by design (user-supplied page specs may contain typos).
+            with contextlib.suppress(ValueError):
                 if len(segments) == 2:
                     start, end = int(segments[0]), int(segments[1])
                     result.update(range(start, end + 1))
                 elif len(segments) == 3 and segments[0] == "":
                     # e.g. "-1" split gives ['', '1']
                     result.add(-int(segments[1]))
                 # More complex cases (e.g. negative range) are ignored.
-            except ValueError:
-                pass
         else:
-            try:
+            with contextlib.suppress(ValueError):
                 result.add(int(part))
-            except ValueError:
-                pass
     return sorted(n for n in result if n > 0)
 
 

openkb/converter.py

@@ -3,7 +3,7 @@
 
 import logging
 import shutil
-from dataclasses import dataclass, field
+from dataclasses import dataclass
 from pathlib import Path
 
 import pymupdf

tests/test_add_command.py

@@ -2,10 +2,8 @@
 from __future__ import annotations
 
 import json
-from pathlib import Path
-from unittest.mock import MagicMock, patch
+from unittest.mock import patch
 
-import pytest
 from click.testing import CliRunner
 
 from openkb.cli import SUPPORTED_EXTENSIONS, _find_kb_dir, cli
@@ -71,7 +69,7 @@ def test_add_single_file_calls_helper(self, tmp_path):
         runner = CliRunner()
         with patch("openkb.cli.add_single_file") as mock_add, \
              patch("openkb.cli._find_kb_dir", return_value=kb_dir):
-            result = runner.invoke(cli, ["add", str(doc)])
+            runner.invoke(cli, ["add", str(doc)])
             mock_add.assert_called_once_with(doc, kb_dir)
 
     def test_add_directory_calls_helper_for_each_file(self, tmp_path):
@@ -85,7 +83,7 @@ def test_add_directory_calls_helper_for_each_file(self, tmp_path):
         runner = CliRunner()
         with patch("openkb.cli.add_single_file") as mock_add, \
              patch("openkb.cli._find_kb_dir", return_value=kb_dir):
-            result = runner.invoke(cli, ["add", str(docs_dir)])
+            runner.invoke(cli, ["add", str(docs_dir)])
             # Should be called for .md and .txt but not .xyz
             assert mock_add.call_count == 2
             called_names = {call.args[0].name for call in mock_add.call_args_list}
@@ -121,7 +119,7 @@ def test_add_skipped_file(self, tmp_path):
 
         runner = CliRunner()
         with patch("openkb.cli._find_kb_dir", return_value=kb_dir), \
-             patch("openkb.cli.convert_document", return_value=mock_result) as mock_conv, \
+             patch("openkb.cli.convert_document", return_value=mock_result), \
              patch("openkb.cli.asyncio.run") as mock_arun:
             result = runner.invoke(cli, ["add", str(doc)])
             assert "SKIP" in result.output

tests/test_agent_tools.py

@@ -1,9 +1,7 @@
 """Tests for openkb.agent.tools — plain function implementations."""
 from __future__ import annotations
 
-from pathlib import Path
 
-import pytest
 
 from openkb.agent.tools import get_wiki_page_content, list_wiki_files, parse_pages, read_wiki_file, write_wiki_file
 

tests/test_cli.py

@@ -1,7 +1,6 @@
 import json
 from unittest.mock import patch
 
-import pytest
 import yaml
 from click.testing import CliRunner
 

tests/test_compiler.py

@@ -2,7 +2,6 @@
 from __future__ import annotations
 
 import json
-from pathlib import Path
 from unittest.mock import MagicMock, patch, AsyncMock
 
 import pytest

tests/test_config.py

@@ -1,5 +1,3 @@
-import pytest
-from pathlib import Path
 from openkb.config import DEFAULT_CONFIG, load_config, save_config