fix(deck-neon): address code-review findings

- SKILL.md: replace stale fixed-px sizes in the slide-grammar table
  (chapter 120px/40px, data 120-160px, copied from the fixed-1280px editorial
  skill) with clamp()/relative values, matching this skill's own clamp()
  mandate; de-ambiguate the --type-label scale row (letter-spacing was in the
  line-height slot); add a 'content must fit one screen, no scroll' rule since
  overflow:hidden + justify-center silently clips tall slides top and bottom
- cli.py / chat.py: derive the deck label from DEFAULT_DECK_SKILL instead of a
  hardcoded literal (the label could silently report the wrong skill after a
  future default change); note the --help default must track the constant
- tests: add test_deck_neon_prompt.py guarding the now-default neon skill's
  frontmatter + od contract (previously only deck-editorial was pinned)

Author: KylinMountain

openkb/agent/chat.py

@@ -659,7 +659,8 @@ async def _handle_slash_deck(arg: str, kb_dir: Path, style: Style) -> None:
     model = config.get("model", DEFAULT_CONFIG["model"])
 
     from openkb.skill.generator import Generator
-    skill_label = skill_name if skill_name else "openkb-deck-neon (default)"
+    from openkb.deck.creator import DEFAULT_DECK_SKILL
+    skill_label = skill_name if skill_name else f"{DEFAULT_DECK_SKILL} (default)"
     _fmt(
         style,
         ("class:slash.help", f"Generating deck '{name}' via skill {skill_label}...\n"),

openkb/cli.py

@@ -2261,6 +2261,8 @@ def deck():
     "--skill", "skill_name",
     metavar="SKILL_NAME",
     default=None,
+    # NOTE: 'openkb-deck-neon' below must stay in sync with
+    # DEFAULT_DECK_SKILL in openkb/deck/creator.py.
     help=(
         "Which deck skill to use. Defaults to 'openkb-deck-neon' "
         "(the built-in). Pass e.g. 'deck-guizang-editorial' to route to "
@@ -2341,7 +2343,8 @@ def deck_new(ctx, name, intent, yes_flag, critique_flag, skill_name):
 
     # Run the generator.
     from openkb.skill.generator import Generator
-    skill_label = skill_name if skill_name else "openkb-deck-neon (default)"
+    from openkb.deck.creator import DEFAULT_DECK_SKILL
+    skill_label = skill_name if skill_name else f"{DEFAULT_DECK_SKILL} (default)"
     click.echo(f"Generating deck '{name}' via skill {skill_label}...")
     gen = Generator(
         target_type="deck",

skills/openkb-deck-neon/SKILL.md

@@ -98,7 +98,7 @@ on a 2560px screen). vw drives the middle value; the rem caps keep it sane:
 * `--type-title`:   clamp(1.9rem, 3.2vw, 3rem)    / 1.12 — normal slide titles
 * `--type-body`:    clamp(1.05rem, 1.4vw, 1.4rem) / 1.6  — body copy (var(--ink))
 * `--type-quote`:   clamp(1.6rem, 2.6vw, 2.2rem)  / 1.35 — pull quotes
-* `--type-label`:   clamp(.66rem, .8vw, .8rem) / .22em uppercase mono — tracks
+* `--type-label`:   size `clamp(.66rem,.8vw,.8rem)`, `letter-spacing:.22em`, uppercase, mono — label tracks
 
 ### Atmosphere (fixed background layers on every slide)
 
@@ -130,6 +130,12 @@ These three layers are what stop the dark background from looking flat/cheap.
 * The aurora, dot-grid, top label row and the bottom signature bar all span the
   FULL viewport width (they live on `.slide`, which is the whole window). Inner
   padding uses the `clamp()` values above so content breathes on any size.
+* **One screen, no scroll — content MUST fit the viewport height.** With
+  `overflow:hidden` + `justify-content:center`, a slide taller than the window
+  is clipped at BOTH top and bottom and is unreachable. Stay within the
+  bullet/word caps (§Failure modes), lean on the `vh` terms in the type scale so
+  text shrinks on short viewports, and if a slide would overflow, CUT content —
+  never let it clip.
 * **Visual signature:** a glowing 3px bar along the bottom edge, gradient
   `teal → sky → magenta`, with `box-shadow:0 0 14px` of --teal. This is the
   deck's signature — present on every slide.
@@ -189,11 +195,11 @@ shrink to a corner. Never size a content box to `min-content`/`fit-content`
 | `data-type` | Use | Neon signature |
 |---|---|---|
 | `cover`   | tag + huge gradient title + 1-line subtitle | strongest aurora; mono "OPENKB" top-left; gradient display title |
-| `chapter` | section divider: oversize number + name | number 120px mono, teal with glow; name 40px display |
+| `chapter` | section divider: oversize number + name | number `clamp(4rem,12vh,9rem)` mono, teal with glow; name in `--type-display` |
 | `thesis`  | one claim + short explanation | title fills ~60% height; ONE keyword in teal+glow; rest --ink |
 | `quote`   | italic pull-quote + attribution | centered; left teal glowing vertical rule; quote in --soft |
 | `compare` | two-column comparison, 3–5 lines each | two glass panels; glowing teal vertical rule between them |
-| `data`    | one number + label + one-line read | number 120–160px gradient+glow; micro-copy 12px mono |
+| `data`    | one number + label + one-line read | number `clamp(3.5rem,11vh,9rem)` gradient+glow (per §Composition); micro-copy in `--type-label` |
 | `closing` | mirrors cover; thanks / next step | same scale as cover; aurora dims toward calm |
 
 Cover/closing have no chapter context → top-left label is "OPENKB".

tests/test_deck_neon_prompt.py

@@ -0,0 +1,90 @@
+"""Sanity tests for the built-in deck-neon skill.
+
+``openkb-deck-neon`` is the DEFAULT deck skill (``DEFAULT_DECK_SKILL`` in
+``openkb/deck/creator.py``), so a typo in its frontmatter or a broken ``od``
+contract would break the most-traveled ``openkb deck new`` path at runtime
+while every other test stayed green. These tests pin the structural anchors
+the validator and generator depend on — mirroring ``test_deck_prompt.py``
+which guards the sibling deck-editorial skill.
+"""
+from __future__ import annotations
+
+from pathlib import Path
+
+from openkb.agent.skills import _parse_frontmatter
+from openkb.deck.creator import DEFAULT_DECK_SKILL
+
+SKILL_MD = (
+    Path(__file__).resolve().parent.parent
+    / "skills"
+    / "openkb-deck-neon"
+    / "SKILL.md"
+)
+
+
+def _load() -> tuple[dict, str]:
+    return _parse_frontmatter(SKILL_MD.read_text(encoding="utf-8"))
+
+
+def test_neon_is_the_default_deck_skill():
+    # The skill dir name, the frontmatter name, and the routed default must agree.
+    assert DEFAULT_DECK_SKILL == "openkb-deck-neon"
+    meta, _ = _load()
+    assert meta.get("name") == "openkb-deck-neon"
+
+
+def test_skill_file_present_and_substantive():
+    assert SKILL_MD.is_file(), f"skill file missing at {SKILL_MD}"
+    meta, body = _load()
+    assert isinstance(meta.get("description"), str) and len(meta["description"]) > 40
+    assert len(body) > 1000, "skill body is suspiciously short"
+
+
+def test_od_contract_is_intact():
+    """run_skill reads od.mode/output_path_template; validate_deck reads
+    od.deck_grammar. A missing key silently skips output enforcement."""
+    meta, _ = _load()
+    od = meta.get("od")
+    assert isinstance(od, dict), "frontmatter must carry an `od:` block"
+    assert od.get("mode") == "deck"
+    assert od.get("output_path_template") == "output/decks/{slug}/index.html"
+    grammar = od.get("deck_grammar")
+    assert isinstance(grammar, dict), "od.deck_grammar must be present"
+    assert grammar.get("kind_attr") == "data-type"
+    assert "cover" in grammar.get("required", [])
+    assert "closing" in grammar.get("required", [])
+    allowed = grammar.get("allowed", [])
+    for t in ("cover", "chapter", "thesis", "quote", "compare", "data", "closing"):
+        assert t in allowed, f"deck_grammar.allowed must include {t}"
+
+
+def test_skill_lists_all_allowed_data_types():
+    _, body = _load()
+    for t in ("cover", "chapter", "thesis", "quote", "compare", "data", "closing"):
+        assert t in body, f"slide grammar must mention data-type={t}"
+
+
+def test_skill_lists_aurora_glass_tokens():
+    _, body = _load()
+    # Neon palette values must appear so the agent can copy them verbatim.
+    for hex_value in ("#080b11", "#2dd4bf", "#38bdf8", "#e879f9", "#f6b94b"):
+        assert hex_value in body, f"palette token {hex_value} missing"
+    assert "JetBrains Mono" in body  # mono stack
+    # Fill-viewport frame, not a fixed card.
+    assert "position:fixed" in body and "inset:0" in body
+
+
+def test_skill_is_self_contained_and_no_web_fonts():
+    _, body = _load()
+    # The deck must be self-contained; the skill must forbid web fonts.
+    assert "self-contained" in body.lower()
+    assert "fonts.googleapis.com" in body  # mentioned as a forbidden pattern
+
+
+def test_skill_description_triggers_on_deck_requests():
+    meta, _ = _load()
+    desc = meta["description"].lower()
+    assert any(
+        word in desc
+        for word in ("deck", "slide", "ppt", "presentation", "演示", "幻灯")
+    )