fix(skill): lock marketplace naming to openkb@vectify convention

The previous impl used the KB directory name as both the marketplace
'name' and the plugin 'name', and stitched together a metadata
description by truncating the first skill's SKILL.md description at
200 chars (often mid-word). Lock the convention to match
skills/openkb/.claude-plugin/marketplace.json from the official skill:

- marketplace name: 'vectify' (always)
- plugin name: 'openkb' (always)
- description: fixed string, no SKILL.md content injection, no truncation

Different KBs are distinguished by <owner>/<repo> URL, not manifest
name. Users get one canonical install command (/plugin install
openkb@vectify) regardless of which KB they're consuming.

Also fix _git_owner to pass cwd=kb_dir so 'openkb --kb-dir ... skill
new' run from anywhere reads the KB's git config, not the process CWD.

Author: KylinMountain

openkb/marketplace.py

@@ -27,11 +27,12 @@
 _DESCRIPTION_RE = re.compile(r"^description:\s*(.+?)\s*$", re.MULTILINE)
 
 
-def _git_owner() -> dict[str, str]:
-    """Read user.name and user.email from git config for the manifest owner.
+def _git_owner(kb_dir: Path) -> dict[str, str]:
+    """Read user.name and user.email from git config (run in kb_dir context).
 
-    Falls back to placeholders if git isn't configured — the manifest is
-    still valid, just less helpful for marketplace listings.
+    Falls back to placeholders if git isn't configured. ``cwd=kb_dir`` so
+    that ``git config`` resolves the KB's local-or-walked-up settings,
+    not the process's working directory at the time of CLI invocation.
     """
     import subprocess
 
@@ -40,6 +41,7 @@ def _git(key: str) -> str:
             result = subprocess.run(
                 ["git", "config", "--get", key],
                 capture_output=True, text=True, timeout=2,
+                cwd=str(kb_dir),
             )
             return result.stdout.strip()
         except (subprocess.SubprocessError, FileNotFoundError):
@@ -71,11 +73,6 @@ def _read_skill_description(skill_md: Path) -> str:
     return desc_match.group(1).strip()
 
 
-def _kb_name(kb_dir: Path) -> str:
-    """Use the KB directory name as the marketplace name (sluggable)."""
-    return kb_dir.name
-
-
 def _list_skill_dirs(kb_dir: Path) -> list[Path]:
     """Return skill directories under <kb>/output/skills/ that contain a SKILL.md."""
     skills_root = kb_dir / "output" / "skills"
@@ -91,32 +88,31 @@ def _build_manifest(kb_dir: Path) -> dict[str, Any]:
     skills = _list_skill_dirs(kb_dir)
     skill_paths = [f"./output/skills/{d.name}" for d in skills]
 
-    # Aggregate description for the manifest metadata
-    name = _kb_name(kb_dir)
+    # Fixed clean descriptions — no truncation, no SKILL.md interpolation.
+    # Naming convention is locked to `openkb@vectify` so users get one
+    # canonical install command regardless of which KB they're consuming;
+    # different KBs are distinguished by <owner>/<repo> URL.
     metadata_desc = (
-        f"Skills compiled from the '{name}' knowledge base via OpenKB."
+        f"Skills compiled from the {kb_dir.name} knowledge base via OpenKB."
     )
-    if skills:
-        first_desc = _read_skill_description(skills[0] / "SKILL.md")
-        if first_desc:
-            metadata_desc += f" Featured: {first_desc[:200]}"
+    plugin_desc = "Knowledge skills compiled from this OpenKB-managed knowledge base."
 
     # Pull KB config for version if available; default to 0.1.0
     config = load_config(kb_dir / ".openkb" / "config.yaml")
     version = str(config.get("version", "0.1.0"))
 
-    owner = _git_owner()
+    owner = _git_owner(kb_dir)
     return {
-        "name": name,
+        "name": "vectify",
         "owner": owner,
         "metadata": {
             "description": metadata_desc,
             "version": version,
         },
         "plugins": [
             {
-                "name": name,
-                "description": metadata_desc,
+                "name": "openkb",
+                "description": plugin_desc,
                 "source": "./",
                 "version": version,
                 "author": owner,

tests/test_marketplace.py

@@ -36,10 +36,8 @@ def test_regenerate_creates_manifest_with_one_skill(tmp_path):
 
     manifest = json.loads((kb / ".claude-plugin" / "marketplace.json").read_text())
     assert manifest["plugins"][0]["skills"] == ["./output/skills/karpathy-thinking"]
-    # The plugin's description carries the SKILL.md description for the latest entry,
-    # OR we use a fixed manifest-level description — implementation choice; we just
-    # check the SKILL.md description appears somewhere in the manifest JSON.
-    assert "Reason like Karpathy" in json.dumps(manifest)
+    # Naming convention is locked: top-level marketplace name is always "vectify".
+    assert manifest["name"] == "vectify"
 
 
 def test_regenerate_lists_multiple_skills_alphabetical(tmp_path):
@@ -67,7 +65,7 @@ def test_regenerate_replaces_existing_file(tmp_path):
     regenerate_marketplace(kb)
 
     manifest = json.loads((kb / ".claude-plugin" / "marketplace.json").read_text())
-    assert manifest["name"] != "stale"
+    assert manifest["name"] == "vectify"
     assert manifest["plugins"][0]["skills"] == ["./output/skills/demo"]
 
 
@@ -155,3 +153,33 @@ def fake_run(cmd, **kwargs):
     assert manifest["owner"]["name"] == "openkb-user"
     # email is optional when missing
     assert "email" not in manifest["owner"] or manifest["owner"]["email"] == ""
+
+
+def test_regenerate_uses_openkb_at_vectify_convention(tmp_path):
+    """All OpenKB-generated marketplaces must self-identify as 'vectify'
+    (top level) with a plugin named 'openkb', so users install via the
+    canonical `openkb@vectify` regardless of which KB they're consuming.
+    Different KBs are distinguished by <owner>/<repo> URL, not manifest name."""
+    kb = _make_kb(tmp_path)
+    _make_skill(kb, "demo", "d")
+    regenerate_marketplace(kb)
+
+    manifest = json.loads((kb / ".claude-plugin" / "marketplace.json").read_text())
+    assert manifest["name"] == "vectify"
+    assert manifest["plugins"][0]["name"] == "openkb"
+
+
+def test_regenerate_description_is_not_truncated(tmp_path):
+    """Manifest description must be a clean fixed string — no truncation
+    of SKILL.md content, no '...' mid-word."""
+    kb = _make_kb(tmp_path)
+    _make_skill(kb, "demo", "the specific description goes here")
+    regenerate_marketplace(kb)
+
+    manifest = json.loads((kb / ".claude-plugin" / "marketplace.json").read_text())
+    # Must not contain the per-skill description (we don't inject it anymore)
+    assert "the specific description goes here" not in manifest["metadata"]["description"]
+    # Must not end with a truncated word (no trailing space-letter-letter etc.)
+    desc = manifest["metadata"]["description"]
+    assert not desc.endswith(" ")
+    assert desc.endswith(".") or desc.endswith("OpenKB.")