style: apply ruff format to add_coordinator.py and test_add_command.py

Author: gwokhou

openkb/add_coordinator.py

@@ -88,9 +88,7 @@ def _failure_target(details: dict) -> str:
 
 def run_add_mutation(kb_dir: Path, plan: AddMutationPlan) -> bool:
     if not kb_ingest_lock_held(kb_dir / ".openkb"):
-        raise RuntimeError(
-            "run_add_mutation requires the caller to hold kb_ingest_lock"
-        )
+        raise RuntimeError("run_add_mutation requires the caller to hold kb_ingest_lock")
     snapshot = None
     try:
         snapshot = snapshot_paths(
@@ -109,9 +107,7 @@ def run_add_mutation(kb_dir: Path, plan: AddMutationPlan) -> bool:
             # than committing more docs on top of dirty state that the next
             # recovery would roll back over.
             raise DirtyRollbackError(plan.operation, dirty_journal)
-        click.echo(
-            f"  [ERROR] {plan.operation} failed{_failure_target(plan.details)}: {exc}"
-        )
+        click.echo(f"  [ERROR] {plan.operation} failed{_failure_target(plan.details)}: {exc}")
         logger.debug("%s mutation failed:", plan.operation, exc_info=True)
         return False
     except BaseException:

tests/test_add_command.py

@@ -114,11 +114,13 @@ def test_add_single_file_uses_add_mutation_coordinator(self, tmp_path):
             doc_name="coordinated",
         )
 
-        with patch("openkb.cli.convert_document", return_value=result), \
-             patch("openkb.cli.publish_staged_tree"), \
-             patch("openkb.cli.asyncio.run"), \
-             patch("openkb.cli._setup_llm_key"), \
-             patch("openkb.add_coordinator.run_add_mutation", return_value=True) as mock_run:
+        with (
+            patch("openkb.cli.convert_document", return_value=result),
+            patch("openkb.cli.publish_staged_tree"),
+            patch("openkb.cli.asyncio.run"),
+            patch("openkb.cli._setup_llm_key"),
+            patch("openkb.add_coordinator.run_add_mutation", return_value=True) as mock_run,
+        ):
             assert add_single_file(doc, kb_dir) == "added"
 
         plan = mock_run.call_args.args[1]
@@ -248,8 +250,10 @@ def test_add_directory_stops_after_dirty_rollback(self, tmp_path):
         )
 
         runner = CliRunner()
-        with patch("openkb.cli.add_single_file", side_effect=dirty_error) as mock_add, \
-             patch("openkb.cli._find_kb_dir", return_value=kb_dir):
+        with (
+            patch("openkb.cli.add_single_file", side_effect=dirty_error) as mock_add,
+            patch("openkb.cli._find_kb_dir", return_value=kb_dir),
+        ):
             with pytest.raises(DirtyRollbackError) as exc_info:
                 runner.invoke(cli, ["add", str(docs_dir)], catch_exceptions=False)
 
@@ -524,9 +528,11 @@ def test_cloud_import_uses_add_mutation_coordinator(self, tmp_path):
         kb_dir = self._setup_kb(tmp_path)
         cloud = self._cloud_data(doc_name="Cloud-Paper")
 
-        with patch("openkb.cli.prepare_cloud_import", return_value=cloud), \
-             patch("openkb.add_coordinator.run_add_mutation", return_value=True) as mock_run, \
-             patch("openkb.cli._setup_llm_key"):
+        with (
+            patch("openkb.cli.prepare_cloud_import", return_value=cloud),
+            patch("openkb.add_coordinator.run_add_mutation", return_value=True) as mock_run,
+            patch("openkb.cli._setup_llm_key"),
+        ):
             assert import_from_pageindex_cloud("cloud-1", kb_dir) == "added"
 
         plan = mock_run.call_args.args[1]
@@ -567,10 +573,12 @@ def race_before_lock(openkb_dir):
             with real_kb_ingest_lock(openkb_dir):
                 yield
 
-        with patch("openkb.cli.prepare_cloud_import", return_value=cloud), \
-             patch("openkb.cli.kb_ingest_lock", side_effect=race_before_lock), \
-             patch("openkb.cli.compile_long_doc", return_value=None), \
-             patch("openkb.cli._setup_llm_key"):
+        with (
+            patch("openkb.cli.prepare_cloud_import", return_value=cloud),
+            patch("openkb.cli.kb_ingest_lock", side_effect=race_before_lock),
+            patch("openkb.cli.compile_long_doc", return_value=None),
+            patch("openkb.cli._setup_llm_key"),
+        ):
             assert import_from_pageindex_cloud("cloud-1", kb_dir) == "added"
 
         registry = HashRegistry(kb_dir / ".openkb" / "hashes.json")
@@ -613,11 +621,13 @@ def register_same_doc_before_second_lock(openkb_dir):
             with real_kb_ingest_lock(openkb_dir):
                 yield
 
-        with patch("openkb.cli.prepare_cloud_import", return_value=cloud) as mock_prepare, \
-             patch("openkb.cli.kb_ingest_lock", side_effect=register_same_doc_before_second_lock), \
-             patch("openkb.cli.compile_long_doc") as mock_compile, \
-             patch("openkb.add_coordinator.run_add_mutation") as mock_run, \
-             patch("openkb.cli._setup_llm_key"):
+        with (
+            patch("openkb.cli.prepare_cloud_import", return_value=cloud) as mock_prepare,
+            patch("openkb.cli.kb_ingest_lock", side_effect=register_same_doc_before_second_lock),
+            patch("openkb.cli.compile_long_doc") as mock_compile,
+            patch("openkb.add_coordinator.run_add_mutation") as mock_run,
+            patch("openkb.cli._setup_llm_key"),
+        ):
             assert import_from_pageindex_cloud("cloud-1", kb_dir) == "skipped"
 
         assert lock_calls["count"] == 2
@@ -639,9 +649,11 @@ def test_cloud_import_propagates_dirty_rollback(self, tmp_path):
             kb_dir / ".openkb" / "journal" / "retained.json",
         )
 
-        with patch("openkb.cli.prepare_cloud_import", return_value=cloud), \
-             patch("openkb.add_coordinator.run_add_mutation", side_effect=dirty_error), \
-             patch("openkb.cli._setup_llm_key"):
+        with (
+            patch("openkb.cli.prepare_cloud_import", return_value=cloud),
+            patch("openkb.add_coordinator.run_add_mutation", side_effect=dirty_error),
+            patch("openkb.cli._setup_llm_key"),
+        ):
             with pytest.raises(DirtyRollbackError) as exc_info:
                 import_from_pageindex_cloud("cloud-1", kb_dir)
 
@@ -658,10 +670,14 @@ def test_cloud_import_failure_message_names_real_cause(self, tmp_path, capsys):
         kb_dir = self._setup_kb(tmp_path)
         cloud = self._cloud_data(doc_name="Cloud-Paper")
 
-        with patch("openkb.cli.prepare_cloud_import", return_value=cloud), \
-             patch("openkb.cli.resolve_doc_name_from_key",
-                   side_effect=RuntimeError("name resolution blew up")), \
-             patch("openkb.cli._setup_llm_key"):
+        with (
+            patch("openkb.cli.prepare_cloud_import", return_value=cloud),
+            patch(
+                "openkb.cli.resolve_doc_name_from_key",
+                side_effect=RuntimeError("name resolution blew up"),
+            ),
+            patch("openkb.cli._setup_llm_key"),
+        ):
             assert import_from_pageindex_cloud("cloud-1", kb_dir) == "failed"
 
         out = capsys.readouterr().out
@@ -678,9 +694,11 @@ def test_cloud_import_keyboard_interrupt_rolls_back_artifacts(self, tmp_path):
         doc_name = "Cloud-Paper"
         cloud = self._cloud_data(doc_name=doc_name)
 
-        with patch("openkb.cli.prepare_cloud_import", return_value=cloud), \
-             patch("openkb.cli.compile_long_doc", side_effect=KeyboardInterrupt()), \
-             patch("openkb.cli._setup_llm_key"):
+        with (
+            patch("openkb.cli.prepare_cloud_import", return_value=cloud),
+            patch("openkb.cli.compile_long_doc", side_effect=KeyboardInterrupt()),
+            patch("openkb.cli._setup_llm_key"),
+        ):
             with pytest.raises(KeyboardInterrupt):
                 import_from_pageindex_cloud("cloud-1", kb_dir)