fix(config): derive global-config lock path from GLOBAL_CONFIG_DIR

_with_global_config_lock() mkdir'd GLOBAL_CONFIG_DIR but opened the lock via the
import-time GLOBAL_CONFIG_LOCK_PATH constant, so the two diverged whenever
GLOBAL_CONFIG_DIR was redirected. Tests monkeypatch GLOBAL_CONFIG_DIR to a tmp
dir but not the lock constant, so the lock opened the real ~/.config/openkb/
global.lock — present on a dev machine, absent on a fresh CI runner — making the
/api/v1/init tests crash with FileNotFoundError (500) only in CI. Derive the
lock path from GLOBAL_CONFIG_DIR at call time so it co-locates with the dir
just created.

Author: KylinMountain

openkb/config.py

@@ -46,7 +46,13 @@
 @contextlib.contextmanager
 def _with_global_config_lock() -> Iterator[None]:
     GLOBAL_CONFIG_DIR.mkdir(parents=True, exist_ok=True)
-    with GLOBAL_CONFIG_LOCK_PATH.open("a+", encoding="utf-8") as fh:
+    # Derive the lock path from GLOBAL_CONFIG_DIR (rather than the import-time
+    # GLOBAL_CONFIG_LOCK_PATH constant) so it always co-locates with the dir we
+    # just created — including when tests monkeypatch GLOBAL_CONFIG_DIR to a
+    # throwaway path. Otherwise the lock would open the real ~/.config/openkb,
+    # which fails on a fresh machine where that dir doesn't exist.
+    lock_path = GLOBAL_CONFIG_DIR / "global.lock"
+    with lock_path.open("a+", encoding="utf-8") as fh:
         flock(fh, exclusive=True)
         try:
             yield