Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Trigger Vencord Update Externally #1080

Closed
3 tasks done
Malix-Labs opened this issue Feb 6, 2025 · 7 comments
Closed
3 tasks done

[Feature Request] Trigger Vencord Update Externally #1080

Malix-Labs opened this issue Feb 6, 2025 · 7 comments
Labels
enhancement New feature or request

Comments

@Malix-Labs
Copy link

Malix-Labs commented Feb 6, 2025

Discord Account

malix_labs (395165536545275905)

Motivation

Vencord updates currently only shows up after Vesktop has been opened, and when there is one, Vesktop needs to be relaunched

Solution

Enabling Vencord to be updated externally (API/CLI, etc...) would make it so Vesktop wouldn't need to be launched for updates

And also enable updates being managed by update managers such as topgrade

Additional context

Request Agreement

  • I have searched the existing issues and found no similar issue
  • This is not a plugin request
  • This is not a Vencord feature request
@Malix-Labs Malix-Labs added the enhancement New feature or request label Feb 6, 2025
@Vendicated
Copy link
Member

Vendicated commented Feb 6, 2025

Do you mean Vesktop Updates, not Discord updates? Aka the notification that says Vesktop has been updated to 1.5.5. Update will be installed when the app is closed

If yes, these are managed by Vesktop itself and just fetched from GitHub releases via https://www.npmjs.com/package/electron-updater

Having external updating would require us to set up an Apt & RPM repo and integrate with the package manager, which we have no interest in at the moment. You can however just do the update manually by fetching the latest GitHub release and seeing if the version matches. If not, download the matching binary and install it

@Malix-Labs
Copy link
Author

Malix-Labs commented Feb 6, 2025

Do you mean Vesktop Updates, not Discord updates?

My Vesktop Vencord and Discord core Vesktop are currently updated, so I do not see the notification toast that says what need to be updated

IIUC, Vesktop flatpak update is updating Vesktop itself and the in-app update is updating Vencord

Is the Vesktop flatpak just a patched Discord flatpak with Vencord pre-injected (which then use the same update mechanism than Vencord)?
If no, could you enlighten me please?

Having external updating would require us to set up an Apt & RPM repo

I was thinking of a simple CLI option to update it when needed, like vinegarhq/sober#634 (almost similar use-case)

@Vendicated
Copy link
Member

Vesktop does not update Discord at all so I'm not sure what you're referring to exactly.

Flatpak updates are for Vesktop itself, while the in-app Updater tab belongs to Vencord and updates Vencord

@Covkie
Copy link
Collaborator

Covkie commented Feb 6, 2025

Sober is a launcher for an app [Roblox] that uses flatpak for self updates while IT does the roblox updates.

Vesktop is an app not a launcher. It updates via electron-updater or via the package manager (ex: Flatpak, just like Sober).

@Malix-Labs
Copy link
Author

Malix-Labs commented Feb 6, 2025

Flatpak updates are for Vesktop itself, while the in-app Updater tab belongs to Vencord and updates Vencord

My bad sorry, I confused namings, I corrected them now

@Malix-Labs Malix-Labs changed the title [Feature Request] Trigger Discord Update Externally [Feature Request] Trigger Vencord Update Externally Feb 6, 2025
@Malix-Labs
Copy link
Author

Malix-Labs commented Feb 6, 2025

Then would it be possible to add a CLI option to trigger vencord updates?

If i'm not mistaken, there are ways to add CLI options to flatpaks (/ call a flatpak app with arguments/flags which can be handled)

@Vendicated
Copy link
Member

Vendicated commented Feb 6, 2025

I don't think this will ever be implemented in Vesktop because it would be extremely niche and I don't really see the point.
If you are annoyed at having to restart after an update was applied - you really don't have to restart right away (unless the update fixes crucial bugs). You can enable auto-updates and disable the update notifications and you won't even know it updated, the update will just apply the next time you restart the app

In any case, the Vencord Installer might have the ability to update vesktop files in the future

And you can always do it manually. Go to Vesktop Settings -> Open Developer Options -> Set Vencord Location to a directory chosen by you. You can now manually download the Vencord files there and manage them yourself (you will have to download the necessary files before selecting it here or Vesktop will tell you the directory is not a valid Vencord install)

This release always has the latest files: https://github.com/Vendicated/Vencord/releases/tag/devbuild. You need all vencordDesktop*.{js,css} files (or even build from source yourself if you so fancy)

@Covkie Covkie closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants