Skip to content

Commit 4cbdbaa

Browse files
joelhawksleyjoelhawksley
authored
Merge pull request #2649 from ViewComponent/release-4-12-0
release 4.12.0
2 parents 6796b2e + a8888e1 commit 4cbdbaa

12 files changed

Lines changed: 28 additions & 20 deletions

‎Gemfile.lock‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PATH
22
remote: .
33
specs:
4-
view_component (4.11.0)
4+
view_component (4.12.0)
55
actionview (>= 7.1.0)
66
activesupport (>= 7.1.0)
77
concurrent-ruby (~> 1)
@@ -184,6 +184,7 @@ GEM
184184
matrix (0.4.3)
185185
method_source (1.1.0)
186186
mini_mime (1.1.5)
187+
mini_portile2 (2.8.9)
187188
minitest (6.0.6)
188189
drb (~> 2.0)
189190
prism (~> 1.5)
@@ -198,6 +199,9 @@ GEM
198199
net-smtp (0.5.1)
199200
net-protocol
200201
nio4r (2.7.5)
202+
nokogiri (1.19.3)
203+
mini_portile2 (~> 2.8.2)
204+
racc (~> 1.4)
201205
nokogiri (1.19.3-aarch64-linux-gnu)
202206
racc (~> 1.4)
203207
nokogiri (1.19.3-aarch64-linux-musl)
@@ -489,7 +493,7 @@ CHECKSUMS
489493
better_html (2.2.0) sha256=e68ab66ab09696b708333bbf35e8aa3c107500ba7892f528e2111624bdd8cf76
490494
bigdecimal (4.1.2) sha256=53d217666027eab4280346fba98e7d5b66baaae1b9c3c1c0ffe89d48188a3fbd
491495
builder (3.3.0) sha256=497918d2f9dca528fdca4b88d84e4ef4387256d984b8154e9d5d3fe5a9c8835f
492-
bundler (4.0.12) sha256=7f8b757d28dfb636e7b24fba2344ac6dd13b5b24f4b46d62573d483f211825ac
496+
bundler (4.0.13) sha256=19f08be7f27022cf0b89f27da0b044ae075e8270a9ef44ad248a932614e1ca3b
493497
capybara (3.40.0) sha256=42dba720578ea1ca65fd7a41d163dd368502c191804558f6e0f71b391054aeef
494498
concurrent-ruby (1.3.6) sha256=6b56837e1e7e5292f9864f34b69c5a2cbc75c0cf5338f1ce9903d10fa762d5ab
495499
connection_pool (3.0.2) sha256=33fff5ba71a12d2aa26cb72b1db8bba2a1a01823559fb01d29eb74c286e62e0a
@@ -530,13 +534,15 @@ CHECKSUMS
530534
matrix (0.4.3) sha256=a0d5ab7ddcc1973ff690ab361b67f359acbb16958d1dc072b8b956a286564c5b
531535
method_source (1.1.0) sha256=181301c9c45b731b4769bc81e8860e72f9161ad7d66dd99103c9ab84f560f5c5
532536
mini_mime (1.1.5) sha256=8681b7e2e4215f2a159f9400b5816d85e9d8c6c6b491e96a12797e798f8bccef
537+
mini_portile2 (2.8.9) sha256=0cd7c7f824e010c072e33f68bc02d85a00aeb6fce05bb4819c03dfd3c140c289
533538
minitest (6.0.6) sha256=153ea36d1d987a62942382b61075745042a2b3123b1cd48f4c3675af9cc7d6f1
534539
minitest-mock (5.27.0) sha256=7040ed7185417a966920987eaa6eaf1be4ea1fc5b25bb03ff4703f98564a55b0
535540
net-imap (0.6.4) sha256=9a5598c67a3022c284d98430ef1d4948e7dbdb62596f61081ea8ca933270a02b
536541
net-pop (0.1.2) sha256=848b4e982013c15b2f0382792268763b748cce91c9e91e36b0f27ed26420dff3
537542
net-protocol (0.2.2) sha256=aa73e0cba6a125369de9837b8d8ef82a61849360eba0521900e2c3713aa162a8
538543
net-smtp (0.5.1) sha256=ed96a0af63c524fceb4b29b0d352195c30d82dd916a42f03c62a3a70e5b70736
539544
nio4r (2.7.5) sha256=6c90168e48fb5f8e768419c93abb94ba2b892a1d0602cb06eef16d8b7df1dca1
545+
nokogiri (1.19.3) sha256=78312cbac32a40c812780d9678221b79d51288eec00054c1a8d15f7ce05960e8
540546
nokogiri (1.19.3-aarch64-linux-gnu) sha256=46b89e5d7b9e844c2ee360794240c6ea2a4e6fa0c5892a4ed487db621224b639
541547
nokogiri (1.19.3-aarch64-linux-musl) sha256=8392dfdcd21be7a94dbbe9ccc138dea01b97b24cb2dc02a114ca98bfb1d9a0b7
542548
nokogiri (1.19.3-arm-linux-gnu) sha256=3919d5ffc334ad778a4a9eb88fda7dcb8b1fb58c8a52ac640c6dcd2f038e774f
@@ -617,7 +623,7 @@ CHECKSUMS
617623
unicode-emoji (4.2.0) sha256=519e69150f75652e40bf736106cfbc8f0f73aa3fb6a65afe62fefa7f80b0f80f
618624
uri (1.1.1) sha256=379fa58d27ffb1387eaada68c749d1426738bd0f654d812fcc07e7568f5c57c6
619625
useragent (0.16.11) sha256=700e6413ad4bb954bb63547fa098dddf7b0ebe75b40cc6f93b8d54255b173844
620-
view_component (4.11.0)
626+
view_component (4.12.0)
621627
warning (1.6.0) sha256=a49cdfae19fb77d19afff2efbe45f8ab759e9cd25b4e4ce2c79dbaf46bdb6c9e
622628
webrick (1.9.2) sha256=beb4a15fc474defed24a3bda4ffd88a490d517c9e4e6118c3edce59e45864131
623629
websocket (1.2.11) sha256=b7e7a74e2410b5e85c25858b26b3322f29161e300935f70a0e0d3c35e0462737
@@ -633,4 +639,4 @@ RUBY VERSION
633639
ruby 4.1.0.dev
634640

635641
BUNDLED WITH
636-
4.0.3
642+
4.0.13

‎docs/CHANGELOG.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ nav_order: 6
1010

1111
## main
1212

13+
## 4.12.0
14+
1315
* Fix stale render context on reused component instances. A `ViewComponent::Base` instance memoized its controller, helpers, request, view context, lookup context, view flow, and requested format details on first render via `||=`. Rendering the same instance a second time (intentionally or via aliasing) reused that stale context, which could leak data across requests, sessions, or users. `#render_in` now resets these ivars on every call so each render derives its context from the current view.
1416

1517
*Joel Hawksley*

‎docs/_data/library.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
version: 4.11.0
1+
version: 4.12.0

‎gemfiles/rails_7.1.gemfile.lock‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PATH
22
remote: ..
33
specs:
4-
view_component (4.11.0)
4+
view_component (4.12.0)
55
actionview (>= 7.1.0)
66
activesupport (>= 7.1.0)
77
concurrent-ruby (~> 1)

‎gemfiles/rails_7.2.gemfile.lock‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PATH
22
remote: ..
33
specs:
4-
view_component (4.11.0)
4+
view_component (4.12.0)
55
actionview (>= 7.1.0)
66
activesupport (>= 7.1.0)
77
concurrent-ruby (~> 1)

‎gemfiles/rails_8.0.gemfile.lock‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PATH
22
remote: ..
33
specs:
4-
view_component (4.11.0)
4+
view_component (4.12.0)
55
actionview (>= 7.1.0)
66
activesupport (>= 7.1.0)
77
concurrent-ruby (~> 1)
@@ -466,7 +466,7 @@ DEPENDENCIES
466466
yard-lint (~> 1.5)
467467

468468
RUBY VERSION
469-
ruby 3.4.4p34
469+
ruby 3.4.4p34
470470

471471
BUNDLED WITH
472-
4.1.0.dev
472+
2.6.9

‎gemfiles/rails_8.1.gemfile.lock‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PATH
22
remote: ..
33
specs:
4-
view_component (4.11.0)
4+
view_component (4.12.0)
55
actionview (>= 7.1.0)
66
activesupport (>= 7.1.0)
77
concurrent-ruby (~> 1)
@@ -467,4 +467,4 @@ RUBY VERSION
467467
ruby 4.0.0p0
468468

469469
BUNDLED WITH
470-
4.1.0.dev
470+
4.0.10

‎gemfiles/rails_main.gemfile.lock‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ GIT
110110
PATH
111111
remote: ..
112112
specs:
113-
view_component (4.11.0)
113+
view_component (4.12.0)
114114
actionview (>= 7.1.0)
115115
activesupport (>= 7.1.0)
116116
concurrent-ruby (~> 1)
@@ -628,7 +628,7 @@ CHECKSUMS
628628
unicode-emoji (4.2.0) sha256=519e69150f75652e40bf736106cfbc8f0f73aa3fb6a65afe62fefa7f80b0f80f
629629
uri (1.1.1) sha256=379fa58d27ffb1387eaada68c749d1426738bd0f654d812fcc07e7568f5c57c6
630630
useragent (0.16.11) sha256=700e6413ad4bb954bb63547fa098dddf7b0ebe75b40cc6f93b8d54255b173844
631-
view_component (4.11.0)
631+
view_component (4.12.0)
632632
warning (1.6.0) sha256=a49cdfae19fb77d19afff2efbe45f8ab759e9cd25b4e4ce2c79dbaf46bdb6c9e
633633
webrick (1.9.2) sha256=beb4a15fc474defed24a3bda4ffd88a490d517c9e4e6118c3edce59e45864131
634634
websocket (1.2.11) sha256=b7e7a74e2410b5e85c25858b26b3322f29161e300935f70a0e0d3c35e0462737

‎gemfiles/rails_main_head.gemfile.lock‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ GIT
110110
PATH
111111
remote: ..
112112
specs:
113-
view_component (4.11.0)
113+
view_component (4.12.0)
114114
actionview (>= 7.1.0)
115115
activesupport (>= 7.1.0)
116116
concurrent-ruby (~> 1)
@@ -580,7 +580,7 @@ CHECKSUMS
580580
unicode-emoji (4.2.0) sha256=519e69150f75652e40bf736106cfbc8f0f73aa3fb6a65afe62fefa7f80b0f80f
581581
uri (1.1.1) sha256=379fa58d27ffb1387eaada68c749d1426738bd0f654d812fcc07e7568f5c57c6
582582
useragent (0.16.11) sha256=700e6413ad4bb954bb63547fa098dddf7b0ebe75b40cc6f93b8d54255b173844
583-
view_component (4.11.0)
583+
view_component (4.12.0)
584584
warning (1.6.0) sha256=a49cdfae19fb77d19afff2efbe45f8ab759e9cd25b4e4ce2c79dbaf46bdb6c9e
585585
webrick (1.9.2) sha256=beb4a15fc474defed24a3bda4ffd88a490d517c9e4e6118c3edce59e45864131
586586
websocket (1.2.11) sha256=b7e7a74e2410b5e85c25858b26b3322f29161e300935f70a0e0d3c35e0462737

‎lib/view_component/base.rb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ def render?
268268
# @private
269269
def render(options = {}, args = {}, &block)
270270
if options.respond_to?(:set_original_view_context)
271-
options.set_original_view_context(self.__vc_original_view_context)
271+
options.set_original_view_context(__vc_original_view_context)
272272

273273
# We assume options is a component, so there's no need to evaluate the
274274
# block in the view context as we do below.

0 commit comments

Comments
 (0)