Better error handling

[AuHau]

Hey there,

first of all thanks for the library!

I would welcome to have better error handling as currently the Error reply is put as JSON into the Exception and not really parsed in anyway.
This makes hard to handle errors which might not really be errors in the application contexts (for example duplicated emails in a list).

I would suggest to extend the current MailChimpError class with status, title and details attribute. Maybe even subclass this class with frequently handled errors, for example like the duplicated emails usecase. Do you know about any other error which would be good to create a subclass for?

I could make PR for this if you would like me to. Please let me know if you would except it.

[stephenross]

Hi

We would be happy to see a PR for what you describe. The current wrapper leaves all error checking in the hands of the users, but if there are any standard errors that you want to provide specific notifications and messages for, we will be glad to take a look at the PR. If you are processing a specific error, please make sure you process that error on every endpoint that raises it.

[OleLaursen]

The three classes of errors I've encountered so far is:

1. Programming errors: bugs in the library or application code, but also a fair share of weird, undocumented limitations in Mailchimp (e.g. you can't have two merge fields with the same name only differing in uppercase/lowercase like "Somefield" and "someField")

2. User input errors, e.g. incorrect email addresses

3. Mailchimp service errors, typically coming from requests, e.g. "Connection refused", or "Connection closed" - typically these are transient and disappear after say an hour but I guess in some cases they could represent errors that require taking action, e.g. a problem with the local network

[lorie-castillano]

Hello everyone! Is there a way I can convert "Mailchimperror" to json format? so I can use it on my web microservice.

[stephenross]

MailChimpError is a custom python exception that we pass json data into, if you wrap your code in a try/except block catching the MailChimpError, you can pull that data out depending on your python version and serve the message information directly.

[rchavik]

Is this the correct way to access the exception data?

try:
    response = client.lists.webhooks.create(...)
except MailChimpError as ex:
    if 'errors' in ex.args[0]:
        raise UserError(ex.args[0]['errors'][0]['message']) #
    else:
        raise ex